Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to Collaboration UI #1508

Closed
Tracked by #1473
danilo04 opened this issue Sep 24, 2021 · 0 comments · Fixed by #1510
Closed
Tracked by #1473

Improvements to Collaboration UI #1508

danilo04 opened this issue Sep 24, 2021 · 0 comments · Fixed by #1510
Labels
consistency Issues created in order to align the UX with other platforms [Type] Enhancement Improve existing functionality.

Comments

@danilo04
Copy link
Contributor

danilo04 commented Sep 24, 2021 •
edited
Loading

Parent #1473

As @SylvesterWilmott, there are some improvements needed in Collaboration UI:

  1. Update the Collaborator UI to use a FAB to add new collaborators. This is more consistent with other parts of the UI eg. Tags. A plus icon can be used within the FAB.
Empty List Collaborators List
image image
  1. It looks like it's possible to add yourself as a collaborator. While we validate the email, let's also make sure that the email doesn't match the email of the currently logged in account. In this event we can show the error `You cannot add yourself as a collaborator in the red error text below the input.
@danilo04 danilo04 added [Type] Enhancement Improve existing functionality. consistency Issues created in order to align the UX with other platforms labels Sep 24, 2021
@danilo04 danilo04 changed the title UI Improvements to Collaboration UI Improvements to Collaboration UI Sep 24, 2021
This was referenced Sep 24, 2021
Closed
Merged
@danilo04 danilo04 added this to the 2.23 milestone Sep 27, 2021
@danilo04 danilo04 removed this from the 2.23 milestone Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
consistency Issues created in order to align the UX with other platforms [Type] Enhancement Improve existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improvements to collaboration UI Automattic/simplenote-android
1 participant
@danilo04