Search follow-up tasks

[codebykat]

Tracking follow-up tasks from #2313:

• Highlight colors are flipped (the dark one should be the current match and all matches should be light)
• Highlight colors overlap and the current match highlight isn't visible in the title
• Scrollbar styling - could be better (Sly's mockups are much prettier with the horizontal lines that match the width of the scrollbar) additionally scrollbars do not match the native ones on e.g. Windows -- tracked in UI spring cleaning: revisit scrollbar styles for search results highlighting #2553
• Bottom of scrollbar gets overlapped by the search results, hiding any highlight at the bottom of the note # - 'N Results' bar blocks last line of long notes #2544 -> Search bar: Make it into its own component in order to fix layout bugs #2545
• Tag field should appear above the search results bar - Search bar: Make it into its own component in order to fix layout bugs #2545
• Selection should be cleared when search is dismissed, instead of leaving a selection of text fix search selection issues #2335
• ESC does not clear the search if the editor has focus fix search selection issues #2335
• On first note load with editor focused, sometimes Cmd+F doesn't focus the search field. Need to try to reproduce this consistently. (see Editor steals focus from search field on load #2530 )
• Similarly sometimes if you load up and immediately focus the search field you end up typing in the note. fix search selection issues #2335
• Hide the search bar with 0 matches in the note (if you do a search with a selected note that doesn't contain the search query)