Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden files not imported #585

Open
nickpagz opened this issue Oct 7, 2024 · 3 comments
Open

Hidden files not imported #585

nickpagz opened this issue Oct 7, 2024 · 3 comments
Labels
Needs triage Ticket needs to be triaged [Pri] Low Studio App [Type] Bug Something isn't working

Comments

@nickpagz
Copy link

nickpagz commented Oct 7, 2024

Quick summary

In at least one scenario, hidden files are not imported when creating a new site while importing from another. I've not comprehensively tested, but noticed the issue when importing an export from a Local site. Upon completion of the import, none of the hidden .git, .github, etc, files were included in the import. I confirmed the files are included in the site export. For further clarity, the sites tested all track wp-content.

Steps to reproduce

  1. With a Local site started (the site must contain hidden files, such as with .git tracking), right-click on the site and choose "Export".
  2. "Add site" in Studio and use the "Import a backup" option, choosing the Local export.
  3. After the import, navigate to site folder where you expect the hidden files to be located. They will not be there.
  4. In my case, the wp-content folder is tracked, and all hidden files were missing on the import.

What you expected to happen

For the hidden files to be imported.

What actually happened

No hidden files were imported.

Impact

One

Available workarounds?

Yes, easy to implement

Platform

Mac Silicon

Logs or notes

No response

@nickpagz nickpagz added [Type] Bug Something isn't working Needs triage Ticket needs to be triaged labels Oct 7, 2024
@Robertght
Copy link

I'm unable to add such a file manually to one of the folders because I'm getting

"You can’t use a name that begins with a dot because these names are reserved for the system. Please choose another name."

@wojtekn please let us know if you need our help testing this and if possible, how to go around the above as some of the workarounds I tried didn't work.

@wojtekn
Copy link
Contributor

wojtekn commented Oct 14, 2024

@Robertght I confirmed the issue. Studio imports paths based on the allow list, so everything besides those directories and files will be skipped:

  • wp-content/uploads/
  • wp-content/plugins/
  • wp-content/themes/
  • wp-config.php

Hidden files inside those directories are imported, though.

@inaikem
Copy link

inaikem commented Oct 15, 2024

@wojtekn, I'm moving this out of triage and adding it to your board for further review with @nickpagz 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs triage Ticket needs to be triaged [Pri] Low Studio App [Type] Bug Something isn't working
Projects
Development

No branches or pull requests

4 participants