Skip to content
This repository has been archived by the owner on Feb 17, 2025. It is now read-only.

Seedlet: link color overridden in the editor #2283

Closed
jffng opened this issue Jul 22, 2020 · 3 comments
Closed

Seedlet: link color overridden in the editor #2283

jffng opened this issue Jul 22, 2020 · 3 comments
Labels
[Theme] Seedlet [Type] Bug Something isn't working

Comments

@jffng
Copy link
Contributor

jffng commented Jul 22, 2020

As of Gutenberg 8.5.1, the default link color is overridden in the editor:

Screen Shot 2020-07-22 at 12 30 51 PM

Screen Shot 2020-07-22 at 12 37 57 PM

This perhaps has something to do with the experimental-link-color feature that was recently introduced. Disabling it doesn't solve this issue, however.

@jffng jffng added [Type] Bug Something isn't working [Theme] Seedlet labels Jul 22, 2020
@kjellr
Copy link
Contributor

kjellr commented Jul 23, 2020

Will this be fixed by #2275?

@Copons
Copy link
Contributor

Copons commented Jul 27, 2020

Will this be fixed by #2275?

Yes!
This line here is how I'm fixing it: https://github.com/Automattic/themes/pull/2275/files#diff-7031c648a477f7ce6558aea53b8a1478R20

I'm not extremely happy about increasing the specificity for such generic rule, though, but I can't think of a better way.
The Guten link color is inlined last (at least in my test environment), and so has precedence over anything else with the same specificity.
.wp-block a shouldn't be a big deal, though, considering that 1) we are targeting blocks anyway; 2) most block-specific override are generally more specific.

@jffng
Copy link
Contributor Author

jffng commented Jul 30, 2020

Closed by #2275.

@jffng jffng closed this as completed Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Theme] Seedlet [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants