Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blank Canvas Blocks] Add block patterns #3415

Closed
jffng opened this issue Mar 8, 2021 · 2 comments
Closed

[Blank Canvas Blocks] Add block patterns #3415

jffng opened this issue Mar 8, 2021 · 2 comments
Assignees
Milestone

Comments

@jffng
Copy link
Contributor

jffng commented Mar 8, 2021

Evaluate each of the block patterns available in Blank Canvas and determine which can be made available in Blank Canvas Blocks without adding any additional custom CSS to the theme.

@kjellr
Copy link
Contributor

kjellr commented Mar 24, 2021

⚠️ EDIT: I left more up-to-date comments in the PR: #3514 (comment).

I took a look at the existing Blank Canvas patterns, and they're looking way off at this point:

A few obvious bugs:

  • Full-width doesn't go full width, there are other content-width errors throughout.
  • The page title is present. (Should I be switching to a different template here? Not sure how that is supposed to work)
  • The theme colors used in the original theme don't match up with those in BCB. This makes some text unreadable, and changes a bunch of the button colors. (Might make sense to hardcode the colors in the patterns instead?)
  • The spacing between blocks is different or wrong.
  • Font weights don't match.

Here's the test content taken right from the original Blank Canvas.

I'm going to hold off on testing again until this is in a closer state, but please let me know if you have any design questions about that stuff.

Blank Canvas Blank Canvas Blocks
dotcomthemes test__p=1040 dotcomthemes test__p=1040

@MaggieCabrera
Copy link
Contributor

Closed via #3514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants