Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quadrat: Navigation #3696

Closed
jffng opened this issue Apr 23, 2021 · 5 comments
Closed

Quadrat: Navigation #3696

jffng opened this issue Apr 23, 2021 · 5 comments

Comments

@jffng
Copy link
Contributor

jffng commented Apr 23, 2021

We need a way to render the menu in a classic theme so there is a sensible upgrade path to FSE while still allowing users to edit their menu in the customizer.

We have three approaches so far:

@jffng jffng added this to the Quadrat v1 milestone Apr 23, 2021
@jffng
Copy link
Contributor Author

jffng commented Apr 30, 2021

We merged #3714 while we push for a solution in Gutenberg / the navigation block.

@MaggieCabrera
Copy link
Contributor

We need to think about the responsive version of the navigation in particular, if the theme launches on dotcom before WordPress/gutenberg#30047 lands

@pbking
Copy link
Contributor

pbking commented May 5, 2021

The ponyfill in BCB gets the current navigation solution (#3714) (or, the location-on-block solution) close-ish as-is for mobile. I think some adjustments either in BCB or Quadrat will get us to useable until that Gutenberg issue lands.

image

@MaggieCabrera
Copy link
Contributor

Oh I forgot about that! cool then, thanks Jason!

@MaggieCabrera
Copy link
Contributor

I think we can close this one since we already have an issue for the mobile menu (#3789). We can revisit this if/when the GB PR for the navigation block lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants