Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quadrat: Mobile Menu Styles #4103

Closed
pbking opened this issue Jun 25, 2021 · 2 comments
Closed

Quadrat: Mobile Menu Styles #4103

pbking opened this issue Jun 25, 2021 · 2 comments
Assignees

Comments

@pbking
Copy link
Contributor

pbking commented Jun 25, 2021

With the usage of the new __unstableLocation block attribute Quadrat lost mobile navigation block support.

This is because the block attributes expressed on the navigation block in the header.html template file (specifically "isResponsive":true) aren't passed to the block renderer when using __unstableLocation.

image

This was intended to fix this very problem but doesn't seem to be working as expected. The fix is likely related in some way though.

While this is specifically problematic for Quadrat with the introduction of __unstableLocation to all BB themes the attributes on the block are lost resulting in incorrect alignment (in Seedlet-Blocks) and the loss of mobile navigation support in all themes should that navigation population method be used.

@pbking
Copy link
Contributor Author

pbking commented Jun 28, 2021

This is addressed in this Gutenberg issue.

@pbking pbking self-assigned this Jun 28, 2021
@scruffian
Copy link
Member

The Gutenberg issue is merged so we can close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants