Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Venture: Group block Wide width issues #4424

Open
mikeicode opened this issue Aug 10, 2021 · 2 comments
Open

Venture: Group block Wide width issues #4424

mikeicode opened this issue Aug 10, 2021 · 2 comments
Labels
[Pri] Normal [Theme] Venture [Type] Bug Something isn't working User Report This issue was created following a WordPress customer report

Comments

@mikeicode
Copy link

Steps to Reproduce

The default Wide width setting for Group blocks no longer makes the inner content wider by default.

  1. Add a Group block set to Wide width
  2. Compare with a Group block set to default width

What I expected to happen

The content of the Wide width block should be wider.

It appears this feature is now used:

Screen Shot 2021-08-10 at 09 56 13

The issue is that any site that previously used blocks set to wide would expect the content to be wider:

Screen Shot 2021-08-10 at 09 57 03

They would now need to manually update every block on the site to make the wide content wider:

Screen Shot 2021-08-10 at 09 59 07

For a site that uses many of these blocks that's an issue.

What actually happened

The default width isn't wider.

Context

4210413-zd-woothemes

An existing site had Group blocks set to Wide width and the width recently changed.

Reviewing a cached older version of the site the Group block used to have wp-block-group__inner-container:

Screen Shot 2021-08-10 at 08 56 54

It no longer does, perhaps related?

Screen Shot 2021-08-10 at 08 57 40

It appears the theme now uses the new settings for the Group block:

WordPress/gutenberg#33359

Ideally there would be a fallback for sites that already had the Group blocks set to Wide width, such as setting values in the new Group block settings to make the content wider by default.

Operating System

macOS

OS Version

10.15.5 (19F101)

Browser

Firefox

Browser Version(s)

90.0.2

Is this specific to applied theme? If so, what is the theme name?

Venture

Simple, Atomic or both?

Simple, Atomic

Console and/or error logs

No response

Number of Users Impacted

Some users (<50%)

Available Workarounds

Manually updating the Group block settings on the site.

Reproducibility

Consistent

Other information

No response

@donalirl
Copy link

Another case of a site affected by this in #4213324-zen, also running the Venture theme

@Robertght
Copy link

I can confirm this is an issue on my end as well and the Full-width alignment appears to behave the same.

@Robertght Robertght transferred this issue from Automattic/wp-calypso Aug 17, 2021
@Robertght Robertght added User Report This issue was created following a WordPress customer report [Type] Bug Something isn't working [Theme] Venture labels Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal [Theme] Venture [Type] Bug Something isn't working User Report This issue was created following a WordPress customer report
Projects
None yet
Development

No branches or pull requests

4 participants