Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some FSE themes: Image block doesn't wrap around text #5843

Open
formosattic opened this issue Mar 13, 2022 · 7 comments
Open

Some FSE themes: Image block doesn't wrap around text #5843

formosattic opened this issue Mar 13, 2022 · 7 comments
Labels
FSE Support Adding support for Full Site Editing to a theme [Pri] Normal [Type] Bug Something isn't working User Report This issue was created following a WordPress customer report

Comments

@formosattic
Copy link

formosattic commented Mar 13, 2022

Quick summary

No response

Steps to reproduce

  1. Add text
  2. Add Image, set it to align left or right

What you expected to happen

To look like this, image wraps around the text:
image1

What actually happened

Image doesn't wrap, is just on the side of the text:

Tested with Twenty Twenty:

image1

Twenty Twenty Two:
image1

Geologist:
image1

Context

Ticket: 4852453-zd-woothemes

Simple, Atomic or both?

No response

Theme-specific issue?

No response

Browser, operating system and other notes

No response

Reproducibility

No response

Severity

No response

Available workarounds?

No response

Workaround details

If it's an FSE theme, having Post Content nested inside the Group block with Post Title and Post Featured Image will fix it.
image1

@formosattic formosattic added [Type] Bug Something isn't working [Pri] Normal User Report This issue was created following a WordPress customer report labels Mar 13, 2022
@Robertght
Copy link

Thank you for reporting this @formosattic ! I tested this further and noticed that the wrapping works ok in a page or a post, but not in the editor:

image

Also, I've tested this with the Post content block inside and outside the group block and the text wrap around the image:

image

Are the screenshots above from the frontend or the editor?

@Robertght
Copy link

I found a case in #4833757-zen where the gallery block needed to be a Group block. The site is using Blank Cavnas.

@formosattic
Copy link
Author

formosattic commented Mar 21, 2022

@Robertght, issue happens in the editor and the live view, though upon testing it again, for the live view, it seems to be impacted by the Inherit default layout setting of the Post Content block, whether it's in a Group block or not may not matter?

Example with Twenty Twenty-Two.

FSE - Single Post template setup

image1

Post - example with image left-aligned

image1

Live view

How it shows with Inherit default layout On and Off.

ON OFF
image1 image2

@Robertght Robertght changed the title Some themes: Image block doesn't wrap around text Some FSE themes: Image block doesn't wrap around text Apr 12, 2022
@Robertght Robertght transferred this issue from Automattic/wp-calypso Apr 12, 2022
@Robertght
Copy link

I'm not 100% sure how much is the theme influencing this, but I'm moving it to the Themes repo for now for more eyes on it.

cc @jeffikus or @MaggieCabrera if we can get more eyes on this. Thanks!

@MaggieCabrera
Copy link
Contributor

I'm pretty sure that was a change in Gutenberg: WordPress/gutenberg#38613

@MaggieCabrera MaggieCabrera added FSE Support Adding support for Full Site Editing to a theme and removed FSE labels Apr 12, 2022
@Robertght
Copy link

As I'm not sure where should this be handled, as we had a recent similar case with Cubic: p1649072900167279-slack-C029FM1EH

cc @jasmussen

@jasmussen
Copy link
Member

@youknowriad I think this is behaving as intended for block themes, right? The aligment to center columns requires another group, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FSE Support Adding support for Full Site Editing to a theme [Pri] Normal [Type] Bug Something isn't working User Report This issue was created following a WordPress customer report
Projects
None yet
Development

No branches or pull requests

4 participants