Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockbase: audit ponyfill for 6.0 #5847

Closed
MaggieCabrera opened this issue Apr 12, 2022 · 8 comments
Closed

Blockbase: audit ponyfill for 6.0 #5847

MaggieCabrera opened this issue Apr 12, 2022 · 8 comments
Labels
Milestone

Comments

@MaggieCabrera
Copy link
Contributor

MaggieCabrera commented Apr 12, 2022

Now that 6.0 is near, we should review Blockbase's CSS and see if we can remove more stuff (and bump the WP required version as we do so).

Any other changes come to mind?

@jeffikus
Copy link
Contributor

Nice work creating this 'overview' issue.

@MaggieCabrera
Copy link
Contributor Author

tagging @beafialho for opinion on adding variations to some of our other themes (maybe livro, archeo, stewart?)

@beafialho
Copy link
Collaborator

@MaggieCabrera this makes sense to me. I'm curious to know your thoughts on adding style variations to all themes from now on, similarly to what we did with patterns? Would like to know @mtias thoughts too.

@MaggieCabrera
Copy link
Contributor Author

@MaggieCabrera this makes sense to me. I'm curious to know your thoughts on adding style variations to all themes from now on, similarly to what we did with patterns? Would like to know @mtias thoughts too.

yes, I think style variations are a great idea, we can add them to the theme as part of the release or afterward like we are doing for other themes like remote, I don't have a preference.

@beafialho
Copy link
Collaborator

I'll add it to my list to create some style variations for Livro, Archeo and Stewart 👍

@mtias
Copy link
Member

mtias commented May 9, 2022

What are these variations about?

@beafialho
Copy link
Collaborator

@mtias these are style variations, as in the TT2 theme.

@mtias
Copy link
Member

mtias commented May 21, 2022

Ah, I misread it as block style variations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants