Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twenty-Twenty & Radcliffe 2: Set Dimensions on blocks "Columns" "Group" #5899

Open
ezebecke opened this issue Jan 24, 2022 · 5 comments
Open
Labels
[Pri] Normal [Theme ]Radcliffe 2 [Theme] Twenty Twenty Triaged [Type] Bug Something isn't working User Report This issue was created following a WordPress customer report

Comments

@ezebecke
Copy link

Quick summary

The Dimensions panel doesn't seem available on some themes. Tested on "Twenty Twenty" and “Radcliffe 2". This might be a thing of older themes not supporting it. This GH comment might suggest that.

Steps to reproduce

1- Activate "Twenty Twenty" or “Radcliffe 2"
2- Add a Column block and look for the "Dimensions" panel

What you expected to happen

To be able to edit block with "Dimensions" panel and set padding.
new-settings

What actually happened

Block show options to change the width only.
column-old

Context

4712282-zd

Simple, Atomic or both?

Simple, Atomic

Theme-specific issue?

"Twenty-Twenty" and “Radcliffe 2".

Browser, operating system and other notes

No response

Reproducibility

Consistent

Severity

No response

Available workarounds?

No response

Workaround details

No response

@ezebecke ezebecke added [Type] Bug Something isn't working User Report This issue was created following a WordPress customer report labels Jan 24, 2022
@sajmes
Copy link

sajmes commented Feb 9, 2022

34087699-hc twenty twenty

@Greatdane
Copy link

@Robertght - do you have any more insight on this, please? Is it just newer, block-based enabled theme that have this function?

@Robertght Robertght transferred this issue from Automattic/wp-calypso Apr 20, 2022
@Robertght Robertght added this to the Bug herding 2022: Week 16 milestone Apr 20, 2022
@mrfoxtalbot mrfoxtalbot changed the title Set Dimensions on blocks "Columns" "Group" Twenty-Twenty & Radcliffe 2: Set Dimensions on blocks "Columns" "Group" Jun 23, 2022
@mrfoxtalbot
Copy link

I have been testing this and it looks like the Padding settings are not being displayed for themes older than Twenty Twenty-One:

Twenty Twenty does not show the padding option:
Screen Shot on 2022-06-23 at 19:08:34

Twenty Twenty-One shows the padding option:
Screen Shot on 2022-06-23 at 19:08:05

Twenty Twenty-Two shows the padding option and a border one:
Screen Shot on 2022-06-23 at 19:10:03

I tested this on WP.com and on a self hosted site with the same results.

I need a second pair of eyes here @Greatdane, @Robertght & @vajrasar: Do we know if these features are only supported for certain themes? It seems unlikely but I could really use a reality check here. Thank you!

@mrfoxtalbot
Copy link

mrfoxtalbot commented Jun 24, 2022

After I little digging I was able to confirm that themes have to opt-in to many of the design tools, or opt-in wholesale with appearanceTools: true. This would explain why padding and border are only available on a few themes.

This probably merits a longer discussion but it would be a good idea to enable these design settings in all of Automattic's themes, whenever possible. Is this something in our radar @jeffikus?

@MaggieCabrera
Copy link
Contributor

appearanceTools is a rule you can only apply on themes with a theme.json file, and I believe the last time we tried to add it to a classic theme it had some consequences, I can't remember which ones now! Right now we are adding that to all of our block themes, but haven't looked again into doing it for classic themes. We'd have to revisit that to see if it's feasible now or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal [Theme ]Radcliffe 2 [Theme] Twenty Twenty Triaged [Type] Bug Something isn't working User Report This issue was created following a WordPress customer report
Projects
None yet
Development

No branches or pull requests

6 participants