Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler: Issues on post-meta pattern and template part #7553

Closed
miksansegundo opened this issue Dec 13, 2023 · 2 comments
Closed

Assembler: Issues on post-meta pattern and template part #7553

miksansegundo opened this issue Dec 13, 2023 · 2 comments
Assignees

Comments

@miksansegundo
Copy link
Contributor

miksansegundo commented Dec 13, 2023

What

There are issues with the post-meta pattern and its template part because they were copied from mpho theme

  1. The post-meta template part uses the slug mpho/post-meta, which is wrong because it should be assembler/post-meta. See
    <!-- wp:pattern {"slug":"mpho/post-meta"} /-->
  2. The pattern should include a comment with Inserter: no because it's not meant to be listed in the inserter. @alaczek can you confirm this?
  3. The pattern uses the wrong pattern category post meta. This category is not registered and is not meant to be used here.

Why

The first issue is the most important because the template is broken.
The second issue shows that pattern in the editor inserter as "uncategorized".
The third issue could fix the second issue if we use a valid category but I believe that pattern should not be in the inserter.

How

  1. use assembler/post-meta as the slug
  2. add the comment Inserter: no
  3. remove the comment Categories: post meta
@richtabor
Copy link
Contributor

In #7538 I've removed the post meta (and a few other templates/parts) that are no longer necessary.

@alaczek
Copy link
Contributor

alaczek commented Dec 14, 2023

It looks like @richtabor already addressed it! That PR should be good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants