Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radcliffe 2 - SVG Icons Not Appearing on Simple Sites #7711

Closed
masperber opened this issue Apr 4, 2024 · 11 comments
Closed

Radcliffe 2 - SVG Icons Not Appearing on Simple Sites #7711

masperber opened this issue Apr 4, 2024 · 11 comments
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] Normal [Pri] TBD [Theme ]Radcliffe 2 Triaged [Type] Bug Something isn't working

Comments

@masperber
Copy link

Quick summary

The Radclfife 2 theme uses some SVG icons in the following areas, and perhaps others:

The above-header contact info: A phone SVG icon appears if the user has entered a phone number, and an envelope SVG icon appears if the user has entered an email address.

The header menu: A hamburger (3 horizontal bars) icon appears on the mobile view if there is a header menu.

On Simple sites, these SVG icons are sometimes not appearing. Atomic sites seem to be unaffected by the issue.

On a customer-reported site, the envelope SVG appeared, but the others did not. On my test site, none of the SVGs appeared.

Steps to reproduce

  1. Start a Simple site with the Radcliffe 2 theme.
  2. In Appearance > Customize > Contact Info, enter a phone number and email address.
  3. In Appearance > Menus add a Header menu.
  4. Verify that the SVGs do not appear in the contact info area.
  5. Verify that the hamburger SVG does not appear on the mobile menu button.

What you expected to happen

All SVGs should appear.

What actually happened

The SVGs do not appear.

Browser

Google Chrome/Chromium, Mozilla Firefox, Microsoft Edge, Apple Safari, iOS Safari, Android Chrome

Context

Customer report, confirmed by testing

Platform (Simple, Atomic, or both?)

Simple

Other notes

No response

Reproducibility

Consistent

Severity

All

Available workarounds?

No but the platform is still usable

Workaround details

Taking the site Atomic could be a workaround if the customer has an appropriate hosting plan.

@masperber
Copy link
Author

7993483-zen customer requests followup when the issue is resolved.

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Support References

This comment is automatically generated. Please do not edit it.

  • 7993483-zen
  • 8025883-zen
  • 7999491-zen
  • 8052490-zen
  • 8068561-zen
  • 8088184-zen
  • 8097264-zen
  • 8105953-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". label Apr 4, 2024
@matticbot matticbot moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Apr 9, 2024
@mrfoxtalbot
Copy link

mrfoxtalbot commented Apr 9, 2024

I can reproduce this issue looking at the theme's demo: https://radcliffe2demo.wordpress.com

Annotation on 2024-04-09 at 16-15-46

I can reproduce it in Chrome, Safari and Firefox, so it is browser-independent.

@mrfoxtalbot
Copy link

I do not think this #1048 is related but I am cross-referencing just in case

@edequalsawesome
Copy link

Also brought up in 8025883-zen

@rosepajaroja
Copy link

7999491-zen

I also want to add that the contact info (address, contact number, and email) is also not visible on mobile and tablet views.

Screen Shot on 2024-04-16 at 21:39:03

@rosepajaroja
Copy link

Additional note:

SVG icons for the submenus also don't show.

Screen Shot on 2024-04-16 at 21:50:04

@liviopv
Copy link

liviopv commented Apr 26, 2024

Moving interactions from duplicate issue:

  • 8052490-zd-a8c
  • 8068561-zd-a8c
  • 8088184-zd-a8c
  • 8097264-zd-a8c
  • 8105953-zd-a8c

@liviopv
Copy link

liviopv commented Apr 26, 2024

Pinged developers who touched the theme on the day before this report here p1714148189202629-slack-C029FM1EH

@miksansegundo
Copy link
Contributor

miksansegundo commented Apr 26, 2024

The icons.svg file is empty after this #7671 tried to compress it.

Photos theme was also affected by this.

I've restored the SVG files in #7773 to fix the issue in Radcliffe 2 and Photos. Will deploy it soon and let you know!

@miksansegundo
Copy link
Contributor

Deployed #7773 🚀

✅ Icons are working on Dotcom Simple sites

Screenshot 2567-04-27 at 02 34 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] Normal [Pri] TBD [Theme ]Radcliffe 2 Triaged [Type] Bug Something isn't working
Development

No branches or pull requests

6 participants