Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammer: essential fixes for Dotcom launch #8627

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

henriqueiamarino
Copy link
Collaborator

@henriqueiamarino henriqueiamarino commented Jan 23, 2025

On this commit, I fixed the following issues commented on #8503:

  • Removed the two Headers that didn't make too much sense;
  • Removed unused custom spaces;
  • Fixed the values for the custom font size presets in the theme.json;
  • Removed both bundled images;
  • Hopefully, after the CBT save parts/post-meta.html is now internationalized;
  • The same is valid for templates/404.html, templates/archive.html, and templates/search.html;
  • Listed the templates in the theme.json, including the new comments;
  • Fixed the main tags in all the templates;
  • Updated info: Tested up to and Requires PHP as needed;
  • Added credits for the font Albert Sans;
  • Added the required No Results paragraph block;
  • Removed duplicated comments in the style.css;
  • Fixed the static font sizes on the 404 template using font size presets;
  • Removed the unneeded tags.

@henriqueiamarino henriqueiamarino self-assigned this Jan 23, 2025
Copy link
Contributor

Preview changes

I've detected changes to the following themes in this PR: Grammer.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@henriqueiamarino
Copy link
Collaborator Author

  • On the last commit, I fixed the Style variation issue;
  • Removed the patterns/home.php, patterns/index.php, and patterns/simple-header-with-image.php;
  • Fixed the Search block issue on the necessary templates;

@iamtakashi
Copy link
Contributor

iamtakashi commented Jan 24, 2025

@henriqueiamarino Thanks for the update! I pushed a change that makes the post meta translation ready.

  • Let's remove those template parts from the theme.json since it's no longer being used.
    CleanShot 2025-01-24 at 15 25 39@2x
  • Sorry, I didn't catch this, but I've noticed that the heading colour was hardcoded #ffffff so it appears like this in the light style variation.
    CleanShot 2025-01-24 at 15 25 57@2x
    CleanShot 2025-01-24 at 15 21 21@2x

Once you fix those, it will be ready to go.

@iamtakashi
Copy link
Contributor

Great. I forgot to point out the misalignment in the footer, but you took care of it. Merging.

@iamtakashi iamtakashi merged commit 45ef705 into trunk Jan 24, 2025
2 checks passed
@iamtakashi iamtakashi deleted the update/grammer-dotcom-improvements branch January 24, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants