Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for payments with asynchronous confirmation in checkout #10124

Closed
gpressutto5 opened this issue Jan 9, 2025 · 0 comments · Fixed by #10219
Closed

Implement support for payments with asynchronous confirmation in checkout #10124

gpressutto5 opened this issue Jan 9, 2025 · 0 comments · Fixed by #10219
Assignees
Labels
focus: checkout payments type: enhancement The issue is a request for an enhancement.

Comments

@gpressutto5
Copy link
Contributor

Description

In #10013 we explored the required work to implement Multibanco as a new payment method. One of the problems encountered listed in paJDYF-ged-p2 is that our gateway is not ready to handle payments with asynchronous confirmation. This is because in WC_Payment_Gateway_WCPay::update_order_status() we only return a success response when the intent is authorized, or a failure response when there’s an error. So the cart is not cleared and the customer is no correctly redirected to the thank you page when the intent still requires action.
We already have the logic to handle webhooks in place, so we only need to implement a way to finalize the order before the payment is confirmed.

Acceptance criteria

  • The order is placed correctly even when the intent still requires an action.

Testing instructions

  1. Use the branch from the Multibanco POC POC: Multibanco #10032
  2. Enable Multibanco
  3. Place an order (test blocks and shortcode checkout)
  4. You should be redirected to the thank you page and the cart is clean
  5. The order is created and its status is on hold.

Additional context

paJDYF-ged-p2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: checkout payments type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant