Fatal error when upgrading to a version with different constructor arguments

[shendy-a8c]

Describe the bug

This bug is discovered when we are requiring new argument for WC_REST_Payments_Disputes_Controller.

When upgrading to a version that requires 2nd argument, it throws a fatal error as if the 2nd parameter isn't passed.

The fatal error is not too harmless. It's only showing and might alert merchants.

To Reproduce

1. Install and activate WCPay.
2. Onboard so store is connected to a Stripe account. I see that if store isn't onboarded yet, I don't see the fatal error.
3. Modify WC_REST_Payments_Disputes_Controller's constructor to accept a new argument and pass that argument from class-wc-payments.php.
4. Run npm run build on that modified code and install + activate the generated woocommerce-payments.zip.

Actual behavior

A fatal error of too few argument will be thrown.

Screenshots

Expected behavior

No fatal error.

Additional context

I laid out a more lengthy explanation here. tl;dr; looks like the older version of class-wc-payments.php is executing while class-wc-rest-payments-disputes-controller.php is updated with newer version within the same runtime.

I think this reported problem is caused by this same problem due to this change.

[htdat]

Sounds like this paJDYF-43G-p2 is relevant.

[shendy-a8c]

Thank you for pointing that out, @htdat. That link is relevant in a way that when a breaking change (like a new constructor parameter) is introduced we have to consider other parties who might depend on it because they might not be aware and the change will break their code.

What surprised me with this issue is that WCPay itself will break on upgrade. The solution might be to avoid breaking changes, ie by making the new constructor argument optional, even though that is not ideal and a bit unclean.

[leonardola]

Seems related to #7464 and #7446

[vbelolapotkov]

@haszari sending this one to your team since the problem is coming from Disputes.

[haszari]

Thanks @vbelolapotkov – added to Helix's board for prioritisation.

[jessy-p]

Not specific to disputes, same as #7464
More information here. paJDYF-aZa-p2

[haszari]

Thanks @jessy-p.

More information here. paJDYF-aZa-p2

Summarising this for clarity. Reminder – P2 links aren't readable and we need to get the relevant context on the issue.

• During update, WooPayments code is running
• The code is being updated as it runs
• This leads to errors when constructor args change, etc

Closing as a duplicate of #7464

If anyone has more info here, and there's something for Helix to action, please comment & reopen or log a new issue.