Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent timezone in jest #5063

Closed
shendy-a8c opened this issue Nov 7, 2022 · 1 comment · Fixed by #5758 · May be fixed by #5064
Closed

Use consistent timezone in jest #5063

shendy-a8c opened this issue Nov 7, 2022 · 1 comment · Fixed by #5758 · May be fixed by #5064
Assignees
Labels
category: engineering For product engineering, architecture work, tech debt and so on. needs prioritisation Triage finished and issues are ready for the following processing. type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@shendy-a8c
Copy link
Contributor

Describe the bug

Currently we use EST as TZ (ref). EST timezone has daylight saving time. This causes GitHub check to fail when there is daylight saving time change.

For example on Nov 6th, 2022, without any code change, GitHub checks that were green (can be seen from this PR and here's the direct link to the green GH check) that was committed as b33be3a became red (can be seen from this my test PR and here's the direct link to the failed GH check).

I think changing the global environment variable TZ to UTC will solve the problem. Some expected values from several tests need to be updated though.

@shendy-a8c shendy-a8c added type: bug The issue is a confirmed bug. needs triage Manually put issue into triage process. type: developer experience and removed type: bug The issue is a confirmed bug. labels Nov 7, 2022
@shendy-a8c
Copy link
Contributor Author

Since using a UTC would require a lot of changes to the existing unit tests, I think we can just update the tests that I quickly patched in #5065 to either:

  • Be daylight saving aware, or
  • Set to use consistent timezone just for those test cases, or
  • Generate the timezone string dynamically instead of using a hardcoded string as of currently.

@jbordonado jbordonado added category: engineering For product engineering, architecture work, tech debt and so on. needs prioritisation Triage finished and issues are ready for the following processing. type: technical debt This issue/PR represents/solves the technical debt of the project. and removed needs triage Manually put issue into triage process. type: developer experience labels Nov 15, 2022
@deepakpathania deepakpathania self-assigned this Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: engineering For product engineering, architecture work, tech debt and so on. needs prioritisation Triage finished and issues are ready for the following processing. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
3 participants