Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split UPE: blocks checkout focus shifts on gateway selection #5557

Closed
frosso opened this issue Feb 15, 2023 · 2 comments · Fixed by #5600
Closed

Split UPE: blocks checkout focus shifts on gateway selection #5557

frosso opened this issue Feb 15, 2023 · 2 comments · Fixed by #5600
Assignees
@FangedParakeet
Labels
category: core WC Payments core related issues, where it’s obvious. component: upe priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: bug The issue is a confirmed bug.

Comments

@frosso
Copy link
Contributor

frosso commented Feb 15, 2023

Describe the bug

When a new Split UPE gateway is selected in the blocks checkout, the page's focus is moved to the top of the checkout page, rather than within the gateway's inner content.
Please investigate whether the issue is within the checkout block or is due to the Split UPE.

Shortcode checkout is not affected by this bug.

To Reproduce

  • Create a page with the shortcode checkout
  • Ensure you have multiple UPE gateways enabled for checkout
  • Add some products to the cart
  • Select one of the UPE gateways
  • Focus is scrolling the page to the top

2023-02-14 19 12 03

Expected behavior

The page should not scroll to the top.
@frosso frosso added type: bug The issue is a confirmed bug. priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. component: upe labels Feb 15, 2023
@frosso frosso mentioned this issue Feb 15, 2023
Merged
4 tasks
@zmaglica
Copy link
Contributor

@frosso is this issue on team Heisenberg's radar? I am triaging the WC Pay backlog, and I am not certain if you are going to handle it.

@zmaglica zmaglica added the category: core WC Payments core related issues, where it’s obvious. label Feb 16, 2023
@frosso frosso added priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. and removed priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. labels Feb 16, 2023
@frosso
Copy link
Contributor Author

frosso commented Feb 16, 2023

@zmaglica the issue is not planned for our current sprint, but it's something that we'll try to tackle in the next sprint. If other teams want to take a stab at it, it's also fine 👍

@FangedParakeet FangedParakeet self-assigned this Feb 22, 2023
@FangedParakeet FangedParakeet mentioned this issue Feb 22, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FangedParakeet FangedParakeet

Labels
category: core WC Payments core related issues, where it’s obvious. component: upe priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes jumping focus on split UPE blocks gateway select Automattic/woocommerce-payments
3 participants
@frosso @FangedParakeet @zmaglica