Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build zip workflow - use minimum PHP required to allow running on older versions of the plugin #6815

Closed
jbordonado opened this issue Jul 19, 2023 · 0 comments · Fixed by #7179
Assignees
Labels
category: devops Features and tools supporting dev process.

Comments

@jbordonado
Copy link
Contributor

Description

In some cases (backport fixes), we may want to run the Build zip file & Run smoke tests on branches that are based on older versions.

Those older versions could have a lower PHP requirement compared to our current production version.

Today, we require minimum PHP 7.3 but last year, we required minimum PHP 7.1.

I can think of two solutions:

  • add an optional PHP version input
  • have the workflow figure out the minimum PHP requirement from the branch it runs on (to be parsed here)

Acceptance criteria

  • We can run the workflow on branches that require lower PHP version compared to the latest version

Additional context

p1689764318051319/1689747102.965849-slack-C05AW31EKFF

@jbordonado jbordonado added the category: devops Features and tools supporting dev process. label Jul 19, 2023
@jbordonado jbordonado changed the title Build zip workflow - use minimum PHP required to allow running on older versions Build zip workflow - use minimum PHP required to allow running on older versions of the plugin Jul 19, 2023
@deepakpathania deepakpathania self-assigned this Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: devops Features and tools supporting dev process.
Projects
None yet
2 participants