Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading state to WooPay button #7295

Closed
bborman22 opened this issue Sep 26, 2023 · 1 comment · Fixed by #7366
Closed

Add loading state to WooPay button #7295

bborman22 opened this issue Sep 26, 2023 · 1 comment · Fixed by #7366
Assignees
Labels
component: WooPay WooPay related issues type: enhancement The issue is a request for an enhancement.

Comments

@bborman22
Copy link
Contributor

Description

The goal of this issue is to add a loading state to the WooPay button to indicate when it is requesting a new checkout session. This discussion (pdpOw2-3Di-p2#comment-3590) will need some input from design on the right implementation of the loading state but would likely include a spinner icon and particularly anything we can pull from existing button loading states.

Acceptance criteria

  • Clicking the WooPay button will display a visual loading indicator while the session request is processing.
  • The shopper will be unable to trigger the session request while the button is in the loading state.
  • Upon success or failure of the session request, the loading state will be removed and the button can be clicked again.
  • The button loading state is approved by design with a demo video in the PR for review.

Designs

TBD

Additional context

This issue is related to the larger WooPay First Party Authentication project.

@bborman22 bborman22 added component: WooPay WooPay related issues type: enhancement The issue is a request for an enhancement. labels Sep 26, 2023
@zmaglica
Copy link
Contributor

This issue impacts WooPay, so assigning to team Heisenberg (based on team responsibilities Pc2DNy-3z-p2) @frosso . Assigning as part of Gamma Triage process PcreKM-yM-p2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: WooPay WooPay related issues type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants