Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced fraud protection erroneously suggests changes may not be saved #8747

Closed
csmcneill opened this issue May 1, 2024 · 0 comments · Fixed by #9521
Closed

Advanced fraud protection erroneously suggests changes may not be saved #8747

csmcneill opened this issue May 1, 2024 · 0 comments · Fixed by #9521
Assignees
Labels
focus: fraud tools type: bug The issue is a confirmed bug.

Comments

@csmcneill
Copy link
Contributor

csmcneill commented May 1, 2024

Describe the bug

When editing the advanced fraud protection settings, there is a warning modal that appears when navigating away from the page:

[siteurl] says

There are unsaved changes on this page. Are you sure you want to leave and discard the unsaved changes?

And selecting the Back to Payments Settings button produces a similar modal with different copy:

Leave site?

Changes you made may not be saved.

This modal appears even if no changes were made or the changes were saved. In my limited testing, I couldn't get this message to not appear.

To Reproduce

  1. Enable advanced fraud protection.
  2. Edit the advanced settings.
  3. Make no changes.
  4. Attempt to navigate to another page.
  5. Note that you receive the warning modal.

Also:

  1. Enable advanced fraud protection.
  2. Edit the advanced settings.
  3. Adjust one of the settings.
  4. Select Save Changes.
  5. Select Back to Payments Settings.
  6. Note that you receive the warning modal.

Actual behavior

There is a warning that changes may not be saved even if no changes were made or changes have been saved. This is unnecessary and adds confusion.

Screenshots

CleanShot 2024-04-30 at 21 06 19

CleanShot 2024-04-30 at 21 00 16

Expected behavior

If there are no pending changes, this warning should not be present.

Additional context

Tested in versions 7.5.3 and 7.6.0-test-2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: fraud tools type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants