Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Create new shared select component – for payments overview currency select initially #8788

Closed
Jinksi opened this issue May 7, 2024 · 1 comment · Fixed by #8896
Closed
Assignees
Labels
category: projects For any issues which are part of any project, including bugs, enhancements, etc. focus: reporting type: epic

Comments

@Jinksi
Copy link
Member

Jinksi commented May 7, 2024

We are creating new UI for selecting currency on the Payment Overview page (#8765). This currency select UI requires a new component as per the design (bIfbBgyBPRzvXEl7dEg3cv-fi-2286_67401).

Image

Differences from existing WooPayments CustomSelectControl component

  • Label positioned inline, aligned left, when inactive.
  • Selected option appears inline next to label, but hidden when select dropdown is open/active
  • When the dropdown is open/active, the selected option marked with a checkmark ✔️, outset to the left of the option label

Future requirements (e.g. for date range select) to be aware of when implementing

  • Hints (descriptions for each select option)
  • The ability to add a second input in a second column with shared state (e.g. calendar input)
  • Apply & reset buttons to confirm selection
  • Search field to filter options

Note a similar component is used for onboarding screens – the CustomSelectControl component for OnboardingSelectField country selector:

image 4

Future

This component will also share use-case with:

These will have extended features, e.g. multiple columns, apply button and a search field. These do not have to be supported by this issue, but should be kept in mind while implementing the currency select.

image 2

image

@Jinksi Jinksi added category: projects For any issues which are part of any project, including bugs, enhancements, etc. focus: reporting labels May 7, 2024
@Jinksi Jinksi self-assigned this May 7, 2024
@Jinksi Jinksi changed the title Create a new React component for the currency switcher select control Create Payment Overview currency switcher select component May 7, 2024
@Jinksi Jinksi removed their assignment May 7, 2024
@Jinksi Jinksi changed the title Create Payment Overview currency switcher select component Create Payment Overview currency select component May 8, 2024
@Jinksi Jinksi changed the title Create Payment Overview currency select component Create new select component – for currency, date-range & country select May 8, 2024
@Jinksi Jinksi changed the title Create new select component – for currency, date-range & country select Create new shared select component – for payments overview currency select initially May 8, 2024
@Jinksi Jinksi changed the title Create new shared select component – for payments overview currency select initially Epic: Create new shared select component – for payments overview currency select initially May 8, 2024
@haszari
Copy link
Contributor

haszari commented May 9, 2024

@Jinksi suggests strategy:

  • Fork (copy) Woo CustomSelectComponent
  • Adapt to our needs and give it a good name
  • (later) Work with Woo core to merge our improvements upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: projects For any issues which are part of any project, including bugs, enhancements, etc. focus: reporting type: epic
Projects
None yet
2 participants