Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ECE Implementation Supports the Same Plugins and Product Types as PRBs #8871

Closed
Tracked by #8768
rafaelzaleski opened this issue May 23, 2024 · 3 comments · Fixed by #8987
Closed
Tracked by #8768

Ensure ECE Implementation Supports the Same Plugins and Product Types as PRBs #8871

rafaelzaleski opened this issue May 23, 2024 · 3 comments · Fixed by #8987

Comments

@rafaelzaleski
Copy link
Contributor

rafaelzaleski commented May 23, 2024

Review the current implementation of the Stripe Express Checkout Element (ECE) api and ensure we are supporting the same product types and plugins as PRBs.

PRBs are currently declaring support for the following product types (some are created by external plugins):

'simple',
'variable',
'variation',
'subscription',
'variable-subscription',
'subscription_variation',
'booking',
'bundle',
'composite',
'mix-and-match',

Acceptance criteria:

  • The ECE implementation supports the same product types/plugins as PRBs.
  • Ensure there are no regressions in Payment Request Buttons (PRB) when ECE is disabled.
  • There are no regressions when no express checkout payment methods are active.
@bborman22
Copy link
Contributor

@rafaelzaleski
Copy link
Contributor Author

@asumaran, I noticed that although we haven’t officially declared support for product types related to WooCommerce deposits, there is code related to this in the PRBs JS files. Could you verify whether PRBs support WooCommerce Deposits and if this functionality is mirrored in ECE?
If not, could you look into this? (in a new PR after #8987 please 😅 )

@asumaran
Copy link
Contributor

asumaran commented Jul 8, 2024

@rafaelzaleski I'll handle it here #9067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants