Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing V2 gateway label icons on V1 checkouts #9826

Open
FangedParakeet opened this issue Nov 27, 2024 · 0 comments · May be fixed by #10005
Open

Implementing V2 gateway label icons on V1 checkouts #9826

FangedParakeet opened this issue Nov 27, 2024 · 0 comments · May be fixed by #10005
Assignees
Labels
focus: checkout payments needs demo PR should provide screenshot or gif of changes to be reviewed by product and design type: enhancement The issue is a request for an enhancement.

Comments

@FangedParakeet
Copy link
Contributor

Description

Stripe has now added a feature to remove the card icon animations on the payment element (see p1732125470634879-slack-C043JN7AJHY). We would now like to continue with replacing the generic card icon added to the payment gateway label in #9483 with the V2 card icons component.

Card gateway icons
This issue concerns 1 and 2 above

We would like to add these icons to both shortcode and blocks checkouts--this can possibly handled in separate issues, if either implementation is deemed individually complex enough.

Note that while this Stripe feature is currently gated to our dev account, we will need to plan how this will be rolled out to all stores. Consequently, while we can complete this integration, we may want to delay on merging and closing this issue, until this rollout plan has been confirmed and aligned.

Acceptance criteria

  • Ensure payment element icons animation is no longer present at checkout.
    • May need to test on gated dev account temporarily, see p1732125470634879-slack-C043JN7AJHY.
  • Implement V2 card icon label badge with tooltip on payment gateway label.
    • This will need to be present on both shortcode and blocks checkouts, though we may decide to divide this into separate issues/PRs.

Designs

Figma
pfHfG4-gT-p2#comment-201

Dev notes

Related to #9331 and #9475.

Additional context

p1732125470634879-slack-C043JN7AJHY
pfHfG4-gT-p2#comment-201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: checkout payments needs demo PR should provide screenshot or gif of changes to be reviewed by product and design type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants