Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize "Zip check" string #9896

Open
aheckler opened this issue Dec 6, 2024 · 0 comments · May be fixed by #9952
Open

Localize "Zip check" string #9896

aheckler opened this issue Dec 6, 2024 · 0 comments · May be fixed by #9952
Assignees
@cesarcosta99
Labels
component: transaction details Issues related to Transaction Details focus: multi-currency priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.
Milestone
WooPayments 8.7.0

Comments

@aheckler
Copy link
Member

aheckler commented Dec 6, 2024

The "Zip check" may make sense to U.S. merchants, but to others it may not. Plus, the capitalization is off.

Image

We should consider an alternative, such as:

  • Changing the string to "Postal code check" to be more generic, or...
  • Dynamically changing the string based on the site language:
    • "ZIP check" for U.S.
    • "Postcode check" for UK
    • "Postal code check" for Canada and elsewhere
@aheckler aheckler added component: transaction details Issues related to Transaction Details needs triage Manually put issue into triage process. type: bug The issue is a confirmed bug. labels Dec 6, 2024
@cesarcosta99 cesarcosta99 self-assigned this Dec 12, 2024
@cesarcosta99 cesarcosta99 added this to the WooPayments 8.7.0 milestone Dec 12, 2024
@pierorocca pierorocca added priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability and removed needs triage Manually put issue into triage process. labels Dec 13, 2024
@cesarcosta99 cesarcosta99 linked a pull request Dec 13, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cesarcosta99 cesarcosta99

Labels
component: transaction details Issues related to Transaction Details focus: multi-currency priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
WooPayments 8.7.0
Development

Successfully merging a pull request may close this issue.

Show "postal code check" label based on store country Automattic/woocommerce-payments
4 participants
@aheckler @c-shultz @cesarcosta99 @pierorocca