Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Genericize instances of "VAT" on Documents page & throughout WooPayments #9923

Closed
aheckler opened this issue Dec 11, 2024 · 1 comment · Fixed by #10055
Closed

Genericize instances of "VAT" on Documents page & throughout WooPayments #9923

aheckler opened this issue Dec 11, 2024 · 1 comment · Fixed by #10055
Assignees
@jessy-p
Labels
category: core WC Payments core related issues, where it’s obvious. focus: tax (VAT) documents good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability
Milestone
WooPayments 8.8.0

Comments

@aheckler
Copy link
Member

Now that Japanese merchants get tax documents/invoices, we should review our whole interface for instaces of:

  • VAT
  • VAT invoice
  • etc.

... and genericize them to something like "Tax invoice" to avoid confusing JP merchants, to whom VAT is irrelevant.

This was partially done in #8974, but we still use VAT language here, for example:

Image
@aheckler aheckler added needs triage Manually put issue into triage process. category: core WC Payments core related issues, where it’s obvious. focus: tax (VAT) documents labels Dec 11, 2024
@haszari haszari changed the title Genericize instances of "VAT" on Documents page Genericize instances of "VAT" on Documents page & throughout WooPayments Dec 11, 2024
@haszari haszari added good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability and removed needs triage Manually put issue into triage process. labels Dec 11, 2024
@haszari
Copy link
Contributor

haszari commented Dec 11, 2024

Adding to Next, would be good to tidy this up 🚀

@jessy-p jessy-p self-assigned this Jan 2, 2025
@jessy-p jessy-p mentioned this issue Jan 2, 2025
Merged
6 tasks
@shendy-a8c shendy-a8c added this to the WooPayments 8.8.0 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessy-p jessy-p

Labels
category: core WC Payments core related issues, where it’s obvious. focus: tax (VAT) documents good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability
Projects
None yet
Milestone
WooPayments 8.8.0
4 participants
@haszari @aheckler @jessy-p @shendy-a8c