Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "currency conversion fee" not "foreign exchange fee" #9996

Closed
aheckler opened this issue Dec 18, 2024 · 0 comments · Fixed by #10002
Closed

Use "currency conversion fee" not "foreign exchange fee" #9996

aheckler opened this issue Dec 18, 2024 · 0 comments · Fixed by #10002
Labels
focus: multi-currency needs triage Manually put issue into triage process.

Comments

@aheckler
Copy link
Member

This issue is a result of this P2 post: pbUcTB-5Uz-p2

TLDR: We should strongly consider moving away from using "foreign exchange fee" when referring to the fee itself, and instead use "currency conversion fee." We can still use "foreign exchange" when talking about the current rate at which one currency converts to another. This matches Stripe's usage.

Instances of "foreign exchange" in code:

https://github.com/search?q=repo%3AAutomattic%2Fwoocommerce-payments+%22foreign+exchange%22&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: multi-currency needs triage Manually put issue into triage process.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant