second pass

Author: obenland

includes/activity/class-activity.php

@@ -52,6 +52,7 @@
  * @method Activity set_attachment( array $attachment ) Sets the attachment property of the object.
  * @method Activity set_icon( array $icon )             Sets the icon property of the object.
  * @method Activity set_image( array $image )           Sets the image property of the object.
+ * @method Activity set_content( string $content )      Sets the content property of the object.
  */
 class Activity extends Base_Object {
 	const JSON_LD_CONTEXT = array(

includes/transformer/class-base.php

@@ -90,7 +90,7 @@ protected function transform_object_properties( $activity_object ) {
 			if ( \method_exists( $this, $getter ) ) {
 				$value = \call_user_func( array( $this, $getter ) );
 
-				if ( isset( $value ) ) {
+				if ( ! empty( $value ) ) {
 					$setter = 'set_' . $var;
 
 					/**

tests/includes/collection/class-test-outbox.php

@@ -194,10 +194,10 @@ public function test_delete_invalidates_all_activities() {
 	/**
 	 * Helper method to create a dummy activity object for testing.
 	 *
-	 * @return \Activitypub\Activity\Base_Object
+	 * @return \Activitypub\Activity\Activity
 	 */
 	private function get_dummy_activity_object() {
-		$object = new \Activitypub\Activity\Base_Object();
+		$object = new \Activitypub\Activity\Activity();
 		$object->set_id( 'https://example.com/test-object' );
 		$object->set_type( 'Note' );
 		$object->set_content( 'Test content' );
@@ -229,7 +229,7 @@ public function test_undo( $type, $expected ) {
 
 		// Only ID for Deletes.
 		if ( 'Delete' === $expected ) {
-			$this->assertSame( get_post( $undo_id )->post_title, $activity->get_object() );
+			$this->assertSame( get_permalink( $id ), $activity->get_object() );
 		} else {
 			$this->assertEquals( json_decode( get_post( $undo_id )->post_content, true ), $activity->get_object()->to_array() );
 		}