Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: include file with default config values #1128

Closed
hoverduck opened this issue Dec 1, 2015 · 2 comments
Closed

Framework: include file with default config values #1128

hoverduck opened this issue Dec 1, 2015 · 2 comments
Labels
Framework [Status] Stale [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@hoverduck
Copy link
Contributor

We have few config values, which are the same in all environments:

[ 'api_transport',
  'i18n_default_locale_slug',
  'rtl',
  'paygate_keys',
  'languages',
  'analytics_event_whitelist',
  'analytics_property_whitelist' ]

Some of them are long and copy/testing seems tedious and error-prone. Also, adding a new config key often means adding it to all configs, which is slightly annoying.

Do you think this is a problem? If yes, what’s the best solution?

My first reaction is to have a common.json, which is loaded in all environments.

I'd like to rework how we handle the configs so that we can build a single bundle and then process that bundle to remove dead code and minify when creating the builds for production and stage. This would remove client/config/regenerate.js and simplify the build process.

@hoverduck hoverduck added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Framework labels Dec 1, 2015
@gziolo
Copy link
Member

gziolo commented Jan 26, 2016

#876 tries to solve the same issue.

@stale
Copy link

stale bot commented Jan 11, 2018

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week. If you would like it to remain open, can you please comment below and see what you can do to get things moving with this issue? Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework [Status] Stale [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

2 participants