Media: Gallery Image order resets on edit

[mahangu]

When editing an existing Gallery in the Editor, the popup modal at first shows the Images in an incorrect order. When accessed for a second time, the modal displays them in the order that they show up in, in the Editor itself (the 'correct' order).

It looks like this may be addressed soon in #8967, but I'm creating a separate issue since this is very likely a bug.

This issue was reported in #3244402-t.

Steps to reproduce

1. Go to https://wordpress.com > My Sites > Blog Posts
2. Load any existing Blog Post that already has a Gallery in it
3. See that the Images in the Gallery are in a certain order
4. Click on the Gallery and hit the pencil icon

5. Observe that in the popup modal, the order of the Images is different

6. Click 'Cancel'
7. Click the Gallery and hit the pencil icon again
8. Observe that the Images are now in the original order

What I expected

I expected the popup modal to show the same Image order as Gallery seen in the Post itself.

What happened instead

A different order of Images is seen in the popup modal.

Browser / OS version

Chrome/FF/Safari on OS X Sierra

Screenshot / Video

https://d.pr/UXcemY

Please let me know if you need any additional info from my end. Thanks!

[folletto]

I'm creating a separate issue since this is very likely a bug.

I agree, seems an unrelated bug.

[KokkieH]

Had another report of this in the public forums in 865461-f, and I experienced it myself last night when editing some gallery posts. In my case and the forum user's, we didn't notice the order had changed in the modal and updated it, leading to the changes being applied to the gallery, so we had to go back and manually fix it so the images can be in the correct order again.

[serabi]

Had another report of this in #649642-zd. The user's gallery will change order in the Calypso preview - he says: "the editor view I get of slide order is often different than the order the slides are presented when viewed as an end user." He has to manually go change the image order for them to be in the correct order again.

[aisajib]

I had another user report this in #3774887-hc and I was able to reproduce this on my test site. The user was pretty upset that they had to reorder the image every time they clicked the edit option for the gallery.

[rachelmcr]

I tested and can reproduce this issue consistently the first time I edit a gallery after reloading Calypso (i.e. after refreshing any page in Calypso). There doesn't seem to be a consistent pattern to how the gallery is reordered — the same gallery may be reordered in different ways each time you reproduce the issue.

I also noticed that if the gallery has columns (e.g. Thumbnail Grid, Square Tiles) the "columns" setting for the gallery is set to 0. This makes me think something is going wrong with componentWillMount() for the gallery here: https://github.com/Automattic/wp-calypso/blob/master/client/post-editor/media-modal/gallery/index.jsx#L43

[github-actions]

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

[mrfoxtalbot]

Hi! I'm performing triage on older bugs as part of the Quality Squad's efforts to cut down on backlog issue counts.

From the screenshot, this seems to be the Calypso editor. I am closing this since we are no longer using it and I was not able to reproduce this using the Classic Block.