Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: blinking trash Icon is a bit confusing #1646

Closed
designsimply opened this issue Dec 15, 2015 · 1 comment
Closed

Editor: blinking trash Icon is a bit confusing #1646

designsimply opened this issue Dec 15, 2015 · 1 comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Milestone
Editor: Next

Comments

@designsimply
Copy link
Contributor

Raised by @akirk

What I Did: Click the trash icon

What I Expected: Clicking the icon would make it ask me if I wanted to delete the post. As it started blinking I figured I could stop the deletion by clicking it again.

What Actually Happened: It started blinking, I clicked it, but kept blinking and after a few seconds redirected me to the post overview page.

What does the blinking indicate? Does it do that until the API responds that the post has been deleted successfully?

Maybe the text in the popover bubble could change from "Send post to the trash" into "Post is being sent to the trash"

Note from @mtias

Maybe the text in the popover bubble could change from "Send post to the trash" into "Post is being sent to the trash"

Good suggestion. It should also disable the action/cursor.
@designsimply designsimply added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Post/Page Editor The editor for editing posts and pages. labels Dec 15, 2015
@designsimply designsimply added this to the Editor: Next milestone Dec 15, 2015
@timmyc
Copy link
Contributor

timmyc commented Mar 16, 2017

This functionality was changed in #11536 - The icon no longer blinks, it now has a text label which reads "Trashing" while the delete operation takes place:

trashing

@timmyc timmyc closed this as completed Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
Editor: Next
Development

No branches or pull requests
2 participants
@timmyc @designsimply