Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User mentions: move React.forwardRef into the higher-order component #24518

Closed
bluefuton opened this issue Apr 27, 2018 · 1 comment
Closed

User mentions: move React.forwardRef into the higher-order component #24518

bluefuton opened this issue Apr 27, 2018 · 1 comment
Labels
[Feature] Reader The reader site on Calypso. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Milestone
Reader: Feature B...

Comments

@bluefuton
Copy link
Contributor

Improvement to user mentions functionality added in #24287.

The higher-order component withUserMentions currently requires the wrapped component to do a React.forwardRef so we can access the DOM node. According to the docs, we can move this ref forwarding into the HOC itself:

https://reactjs.org/docs/forwarding-refs.html
@bluefuton bluefuton added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Reader The reader site on Calypso. labels Apr 27, 2018
@bluefuton bluefuton added this to the Reader: add @mentions milestone Apr 27, 2018
@bluefuton bluefuton mentioned this issue Apr 30, 2018
Merged
@bluefuton
Copy link
Contributor Author

Some related discussion about Redux connect() and forwardRef:

reduxjs/react-redux#914

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Reader The reader site on Calypso. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
Reader: Feature Backlog
Development

No branches or pull requests
1 participant
@bluefuton