Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Site Editing: improve content slot block interactions [5] #34344

Closed
vindl opened this issue Jun 27, 2019 · 5 comments
Closed

Full Site Editing: improve content slot block interactions [5] #34344

vindl opened this issue Jun 27, 2019 · 5 comments

Comments

@vindl
Copy link
Member

vindl commented Jun 27, 2019

When editing a page that shows the header and footer template parts in the same view, we need to click twice on post content slot in order to start editing some of its inner blocks.

Let's try to improve this in order to avoid the need for an extra click.

@mmtr
Copy link
Member

mmtr commented Jun 28, 2019

This PR might be relevant to understand how the click-through approach (first click to select parent, second one to select a child) has been implemented in Gutenberg:

WordPress/gutenberg#15537

@kwight
Copy link
Contributor

kwight commented Jun 28, 2019

With WordPress/gutenberg#15537 merged, does that mean this can be closed?

@mmtr
Copy link
Member

mmtr commented Jun 29, 2019

With WordPress/gutenberg#15537 merged, does that mean this can be closed?

No no, I just referenced it because that's where the two clicks to edit a nested block was implemented, so it might give us a clue on how to disable that behavior.

@gwwar gwwar changed the title Full Site Editing: improve content slot block interactions [?] Full Site Editing: improve content slot block interactions [5] Jul 1, 2019
@vindl vindl removed this from the Cylon+Serenity Sprint [27-28] milestone Jul 15, 2019
@noahtallen
Copy link
Contributor

It looks like they may be reverting it: WordPress/gutenberg#16888

@davipontesblog
Copy link
Contributor

I am closing this in favor of the current efforts with core FSE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants