Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(?P) Add tests for missing images in gallery full-screen preview on front of site #35629

Closed
apeatling opened this issue Aug 20, 2019 · 1 comment

Comments

@apeatling
Copy link
Member

apeatling commented Aug 20, 2019

See p58i-7RD-p2#comment-42220

if you don’t replace the images in the gallery on the Portfolio template when you view the page on the front of the site and click one of the images to bring up the full screen view, you get a blank image. However, when you replace the images with your own, then you do see the full screen images.

This is more complicated than it looks.

See

@obenland obenland changed the title (6P) Portfolio Template missing images in gallery full-screen preview on front of site (?P) Add tests for missing images in gallery full-screen preview on front of site Aug 21, 2019
@obenland
Copy link
Member

obenland commented Oct 1, 2019

We will not be working on this. Image side loading could have been a way to prevent this bug, but we won't move forward with that either, given the high amount of data we'd be pushing around.
This really should just be fixed in Jetpack.

@obenland obenland closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants