Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Site Editing: Add styling options to the Navigation Menu block #36605

Closed
Copons opened this issue Oct 8, 2019 · 3 comments · Fixed by #36686
Closed

Full Site Editing: Add styling options to the Navigation Menu block #36605

Copons opened this issue Oct 8, 2019 · 3 comments · Fixed by #36686

Comments

@Copons
Copy link
Contributor

Copons commented Oct 8, 2019

Currently, the Full Site Editing's Main Navigation block doesn't have any styling options (except the wide/full block width), and simply reuses the theme CSS .main-navigation class styles.

We should keep the theme CSS as default and fallback, but also let the user set their own styling options.

@noahtallen
Copy link
Contributor

should we punt this in favor of core work?

@Copons
Copy link
Contributor Author

Copons commented Oct 9, 2019

should we punt this in favor of core work?

I'd love to add the same attributes as we are adding to the Site Title and Description.
Here colors are more annoying because menus are inherently more complicated, but it might be worth a try.

@apeatling
Copy link
Member

apeatling commented Oct 11, 2019

@Copons I would only try this if it is one day of work, the colors work is almost already completed on the core navigation block from Ajax: WordPress/gutenberg#17832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants