Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPress: Newly-converted Video blocks are not playable. #36836

Closed
kwight opened this issue Oct 16, 2019 · 4 comments
Closed

VideoPress: Newly-converted Video blocks are not playable. #36836

kwight opened this issue Oct 16, 2019 · 4 comments
Labels
[Feature] VideoPress A feature to help you upload and insert videos on your site. [Type] Bug

Comments

@kwight
Copy link
Contributor

kwight commented Oct 16, 2019

Once a VideoPress block finishes uploading and converting, it displays its UI. However, the UI is inaccessible (it's not possible to click on the Play button for example).

The preview ends up being an iframe within an iframe, which could be related.

@kwight kwight added [Type] Bug [Feature] VideoPress A feature to help you upload and insert videos on your site. labels Oct 16, 2019
@mmtr
Copy link
Member

mmtr commented Oct 17, 2019

It is not the first time this issue comes up 🙂. As said in D30868-code, this behavior is intentional:

I also can't play the video at all, or interact with any of the controls. (This is the case with two videos I've had in my library for a while; a new VideoPress video added by URL is fully interactive)

This is expected because we deliberately disable the video player so users don't interact accidentally with it when they want to focus the block (#). Gutenberg also does the same with the default core/video block (#).

You can interact with the player when adding the video via URL because Gutenberg doesn't render the Disabled component on core/embed blocks (core/video blocks are transformed to core/embed when using URLs).

Should we diverge from what core/video does and remove the disabled layer?

@kwight
Copy link
Contributor Author

kwight commented Oct 17, 2019

Lol, my memory is so short sometimes 🙃

Intentional or not, it's hard not to see it as just broken from a user's point of view 🤔 My first thought was that this should work like nested?inner? blocks, where the first click is the parent (disabled) block, and the second click would be the inner video, with active UI. Looks like this was called Clickthrough, and was disabled for desktop (presumably kept for mobile?), because desktops have enough padding to allow clicking the padding to select the block itself. If all this works as explained, it makes me wonder why the core Video block is disabled; need to play with it.

@mmtr
Copy link
Member

mmtr commented Oct 30, 2019

Found some context about why Core disables the controls: WordPress/gutenberg#7929 (comment)

There is an open issue asking for a better visual on the video controls when they are disabled: WordPress/gutenberg#9252

@kwight
Copy link
Contributor Author

kwight commented Oct 30, 2019

I'm happy to close this in deference to WordPress/gutenberg#9252 then.

@kwight kwight closed this as completed Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] VideoPress A feature to help you upload and insert videos on your site. [Type] Bug
Projects
None yet
Development

No branches or pull requests

2 participants