-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seedlet: Custom link colors not rendered on frontend #45456
Comments
I could repro this issue in a dotorg setup with an author role, see WordPress/gutenberg#25151 In dotcom, I experienced this by testing with an admin role. |
@sirreal @scruffian Got a potential fix for this at WordPress/gutenberg#25411 Note, however, what I reported above: it looks like dotcom may be doing additional things to what core does, so it's worth looking into that separately. |
Ah, it'd be great if you have a way to report whether the fix works for dotcom as it is. |
@nosolosw, I installed the build from WordPress/gutenberg#25411 in D50012-code & tested in on my side but it doesn't seem like this patch alone fixes the issue:
|
@nosolosw has there been any follow-up regarding this issue on dotcom? This seems to be still happening. |
I can't speak for dotcom but, for core, we're going to revisit how to fix this (see comment). |
Context: There was a Seedlet theme update, which is why we revisited 🙂 |
Let's revisit this when 9.2 lands. |
I don't believe this is a theme issue, so I'm going to remove it from our board. If you disagree let me know! |
This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels. |
I think this is the same as this one: #54990 I'm marking this as a duplicate now in favor of the above. |
Steps to reproduce
Note that custom background and text colors (rendered as
background-color
andcolor
in astyle
attribute) are respected. The custom link color is not.cc: @jeffikus
What I expected
Render the link color.
What happened instead
The link color is not respected.
Screenshot / Video
It says "green" but the link _should be
#ff00ff
"pink".Editor
Frontend
Context / Source
The text was updated successfully, but these errors were encountered: