Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seedlet: Custom link colors not rendered on frontend #45456

Closed
sirreal opened this issue Sep 8, 2020 · 12 comments
Closed

Seedlet: Custom link colors not rendered on frontend #45456

sirreal opened this issue Sep 8, 2020 · 12 comments
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Pri] Low Address when resources are available. [Status] Stale [Type] Bug When a feature is broken and / or not performing as intended

Comments

@sirreal
Copy link
Member

sirreal commented Sep 8, 2020

Steps to reproduce

  1. Activate Seedlet on a Simple site
  2. Open the block editor and write a paragraph with a link.
  3. From the block controls, expand color settings and change the link color.
  4. Publish the post and view it on the site (example post: paqfU8-tn-p2)
  5. The link color will not be rendered on the frontent.

Note that custom background and text colors (rendered as background-color and color in a style attribute) are respected. The custom link color is not.

cc: @jeffikus

What I expected

Render the link color.

What happened instead

The link color is not respected.

Screenshot / Video

It says "green" but the link _should be #ff00ff "pink".

Editor

Screen Shot 2020-09-08 at 12 53 00
Screen Shot 2020-09-08 at 12 52 36

Frontend

Screen Shot 2020-09-08 at 12 51 33

Screen Shot 2020-09-08 at 12 51 44

Context / Source

@sirreal sirreal added [Goal] Gutenberg Working towards full integration with Gutenberg [Type] Bug When a feature is broken and / or not performing as intended labels Sep 8, 2020
@oandregal
Copy link
Contributor

I could repro this issue in a dotorg setup with an author role, see WordPress/gutenberg#25151 In dotcom, I experienced this by testing with an admin role.

@oandregal
Copy link
Contributor

@sirreal @scruffian Got a potential fix for this at WordPress/gutenberg#25411 Note, however, what I reported above: it looks like dotcom may be doing additional things to what core does, so it's worth looking into that separately.

@oandregal
Copy link
Contributor

Ah, it'd be great if you have a way to report whether the fix works for dotcom as it is.

@WunderBart
Copy link
Member

WunderBart commented Sep 22, 2020

Ah, it'd be great if you have a way to report whether the fix works for dotcom as it is

@nosolosw, I installed the build from WordPress/gutenberg#25411 in D50012-code & tested in on my side but it doesn't seem like this patch alone fixes the issue:

Editor Preview
Screenshot 2020-09-22 at 15 46 59 Screenshot 2020-09-22 at 15 47 09

@WunderBart
Copy link
Member

@nosolosw has there been any follow-up regarding this issue on dotcom? This seems to be still happening.

@oandregal
Copy link
Contributor

I can't speak for dotcom but, for core, we're going to revisit how to fix this (see comment).

@sirreal
Copy link
Member Author

sirreal commented Oct 6, 2020

has there been any follow-up regarding this issue on dotcom? This seems to be still happening.

Context: There was a Seedlet theme update, which is why we revisited 🙂

@WunderBart
Copy link
Member

Let's revisit this when 9.2 lands.

@andrewserong
Copy link
Member

Just confirming that this is still an issue in wpcom with Seedlet theme activated.

In the editor, with a custom link color set (to red):

image

In the front end:

image

@andrewserong andrewserong added the [Pri] Low Address when resources are available. label Nov 23, 2020
@scruffian
Copy link
Member

I don't believe this is a theme issue, so I'm going to remove it from our board. If you disagree let me know!

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@Robertght
Copy link

Robertght commented Oct 8, 2021

I think this is the same as this one: #54990

I'm marking this as a duplicate now in favor of the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg [Pri] Low Address when resources are available. [Status] Stale [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

6 participants