Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Icons block: Show more icons: Browse All button shows blocks, not icons #46382

Closed
alaczek opened this issue Oct 13, 2020 · 3 comments
Closed
Labels
Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions [Feature] Post/Page Editor The editor for editing posts and pages. [Pri] Low Address when resources are available. [Status] Stale [Type] Bug

Comments

@alaczek
Copy link
Contributor

alaczek commented Oct 13, 2020

I'm not 100% sure this issue belongs here, so I'm happy to move it elsewhere.

Steps to reproduce

  1. Create a new post or a page and add the Social Icons block.
  2. Click on the + button within the block. Note that only 6 more icons are shown in the popup, even though more are available.
  3. Click the Browse all button at the bottom. It will open the left sidebar with the list of all available blocks, not a full list of available social media icons that I expected since I started within the context of Social Icons block.

The same issue is present in Gutenberg (WordPress/gutenberg#26046), although it's less prominent because Gutenberg shows a longer list in the popup.

What I expected

I expected to be able to see the full list of available social media icons. If what happens after clicking the "Browse all" button is controlled by Gutenberg, could we display the longer list when the person clicks the + button (basically, could we make the behavior identical as in core?).

Screenshot / Video

Here's the popup in question on WordPress.com:
image

Here's the same popup in core:
gwz5AO1HW9

Here's the video of the whole issue, and confusion upon landing on a list of all available blocks:
nfWPHDsJZ0

@cathymcbride cathymcbride changed the title Social Icons block: Show more icons Social Icons block: Show more icons: Browse All button shows blocks, not icons Oct 13, 2020
@cathymcbride cathymcbride added [Pri] Low Address when resources are available. [Type] Bug Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions [Feature] Post/Page Editor The editor for editing posts and pages. labels Oct 13, 2020
@obenland
Copy link
Member

@olaolusoga Could this one be a duplicate of WordPress/gutenberg#25474? If not, could you help me understand the difference?

@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@Robertght
Copy link

I cannot replicate this anymore, so I'm closing this one, but here are my results after I click on "browse all"

Gutenberg: v11.7.0-rc.1

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions [Feature] Post/Page Editor The editor for editing posts and pages. [Pri] Low Address when resources are available. [Status] Stale [Type] Bug
Projects
None yet
Development

No branches or pull requests

4 participants