-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features using alert()
, confirm()
or prompt()
break in Chrome >= 92 when editor is iframed (including post privacy settings)
#54781
Comments
cc @Automattic/team-calypso-frameworks |
alert()
, confirm()
or prompt()
break in Chrome >= 92 when editor is iframed
Chrome 92 started blocking modals like This needs a fix on the Gutenberg side, abandoning We can do a workaround on the Calypso iframe side by intercepting |
One case in 4182598-zen As a workaround, I recommended using the Classic editor. |
I had a report in #30840168-hc I also experienced this problem myself in my own WordPress.com account. I use Chrome Version 92.0.4515.107 (Official Build) (x86_64). Video showing the issue that nothing happens when I click on the |
Another report in https://wordpress.com/forums/topic/can-make-posts-to-private/ They report it also happens in Edge, though I'm not able to reproduce it there. I can reproduce in Chrome. |
Another report: 4181858-zd-woothemes |
alert()
, confirm()
or prompt()
break in Chrome >= 92 when editor is iframedalert()
, confirm()
or prompt()
break in Chrome >= 92 when editor is iframed (including post privacy settings)
Another report: 19996224-hc |
Reported here: 4180786 |
This report was found during a recent backlog sweep. 📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain
📌 FINDINGS/SCREENSHOTS/VIDEO
maDUvy.mp4📌 ACTIONS
|
Steps to reproduce the behavior
*check the JS console warnings and you'll see why.
UPDATE: It also happens with the "Switch to draft" button.
What I expected to happen
I expect the confirmation JS dialog to appear and to be able to confirm that or cancel the operation of setting the post as private.
What actually happened
Nothing. Clicking the "Private" radio-button doesn't do anything. It just outputs a warning in the Chrome JS console.
Context
It seems it has been decided that cross-origin iframes can't trigger dialogs anymore as it was considered bad UX and a possible security breach. See: https://www.chromestatus.com/feature/5148698084376576. It has been active as a "trial" since Chrome 92 (and apparently until v96), see: https://developer.chrome.com/origintrials/#/view_trial/2541156089743802369.
For now, it only manifests in Chrome 92, but it might be a problem in Firefox and Safari soon, too (and possibly other browsers in the longer term):
This is not specific to Gutenberg at all. If you open the edit post page directly from
wp-admin
, everything works as expected (see screencast at the bottom of this issue).Browser / OS version
92.0.4515.107 (Official Build) (64-bit)
, Linux.Is this specific to the applied theme? Which one?
No.
Does this happen on simple or atomic sites or both?
Possibly both, but only tried in simple sites so far.
Is there any console output or error text?
Yes:
Level of impact (Does it block purchases? Does it affect more than just one site?)
Reproducibility (Consistent, Intermittent) Leave empty for consistent.
Screenshot / Video: If applicable, add screenshots to help explain your problem.
Peek.2021-07-21.17-54.mp4
I'm using an older Gutenberg release in these tests as you may see the in the screencast above. I did that to rule out it being a problem introduced by the recent upgrades. It's not. It happens consistently with an older or a more recent release.
The text was updated successfully, but these errors were encountered: