Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain: Expiring notice overflow #6098

Closed
umurkontaci opened this issue Jun 16, 2016 · 5 comments
Closed

Domain: Expiring notice overflow #6098

umurkontaci opened this issue Jun 16, 2016 · 5 comments
Assignees
@umurkontaci
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management. [Pri] Low Address when resources are available. [Type] Bug When a feature is broken and / or not performing as intended
Milestone
Domain Design Mai...

Comments

@umurkontaci
Copy link
Contributor

The expiring notice on the sidebar is overflowed when the domain name is a bit long.

image

@breezyskies is there a way to force linebreak here?
@umurkontaci umurkontaci added [Pri] Low Address when resources are available. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Feature Group] Emails & Domains Features related to email integrations and domain management. labels Jun 16, 2016
@umurkontaci umurkontaci self-assigned this Jun 16, 2016
@breezyskies
Copy link
Contributor

word-wrap: break-word; should work.

@klimeryk klimeryk added this to the Cobalt: Backlog milestone Aug 1, 2016
@klimeryk
Copy link
Contributor

klimeryk commented Aug 1, 2016

Worth revisiting this issue after #3329 is merged and this notice is displayed as the compact version.

@klimeryk
Copy link
Contributor

Unfortunately, word-wrap alone doesn't seem to do the trick :/
screen shot 2016-08-15 at 13 24 48

The problem seems to be that behind the scenes, the notice is expanded (flex grow probably) as needed:
screen shot 2016-08-15 at 13 43 53

Probably best if a designer looked at this and found a proper fix (since we don't want to break compact notices in other parts of the application).

@breezyskies
Copy link
Contributor

Adding this to our backlog but probably won't get to it soon.

@umurkontaci
Copy link
Contributor Author

95% of .com domains are less than 28 characters. It'll fit :) This might only be a problem with subdomain mappings.

@lancewillett lancewillett added the [Type] Bug When a feature is broken and / or not performing as intended label Sep 2, 2016
@umurkontaci umurkontaci mentioned this issue Nov 10, 2016
Closed
@mikeshelton1503 mikeshelton1503 mentioned this issue Jul 5, 2017
Merged
@matticbot matticbot removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@umurkontaci umurkontaci

Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management. [Pri] Low Address when resources are available. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
Domain Design Maintenance
Development

No branches or pull requests
6 participants
@lancewillett @umurkontaci @breezyskies @klimeryk @mikeshelton1503 @matticbot