Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant "Move to" block widgets across widget areas #62545

Closed
happychait opened this issue Apr 6, 2022 · 9 comments
Closed

Cant "Move to" block widgets across widget areas #62545

happychait opened this issue Apr 6, 2022 · 9 comments
Assignees
Labels
Block Widgets Build Maintenance Build Group maintenance tasks [Closed] Resolved Issue is resolved. Use for issues that can be closed but did not have an explicit fix with a PR. Legacy Widgets [Pri] Normal [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@happychait
Copy link

happychait commented Apr 6, 2022

Quick summary

The Move to options on the WP-Admin widgets and Customizer widgets screens don't do anything!

Steps to reproduce

  1. Open the WP-Admin Widgets page from /wp-admin/widgets.php

  2. Click on any widget, three dots, and select Move to

  3. Open the Customizer → Widgets → any widget area → any existing widget.

  4. Click on the three dots on any widget, and click on Move to

What you expected to happen

The Move to option should open other available widget areas to move the widget to.

What actually happened

Nothing happens when I click on Move to. It is totally unresponsive.

Context

User report in 19460407-hc followed up in 4924856-zen

Simple, Atomic or both?

No response

Theme-specific issue?

No response

Browser, operating system and other notes

No response

Reproducibility

No response

Severity

No response

Available workarounds?

Yes, easy to implement

Workaround details

In the WP-Admin Widgets screen, we can drag-drop the widgets as shown in this video:

Captured.at.06-04-2022.at.12.19.52.mp4
@happychait happychait added [Type] Bug User Report This issue was created following a WordPress customer report labels Apr 6, 2022
@happychait
Copy link
Author

I tested a bit more with an Atomic site, and found the Move to doesn't work on the WP-Admin Widgets screen.

But in the customer, Move to menu option is unresponsive and does nothing, but the Move to widget area icon on the widget toolbar works as in this screenshot:
Atomic Move to

@vajrasar
Copy link

vajrasar commented Apr 16, 2022

Thanks @happychait for the details bug report and the comments.

I checked and on the AT site - I was able to replicate all the parts of the issue ("Move To" not working either on wp-admin widgets section and also not on the Customizer section, whereas the "Move to icon" works in the customizer and wp-admin widgets section as expected).

However, on the Simple site, the issue (as above) persists, and the only change is that you cannot find the "Move To" option on the widget by clicking on three-dots. Only the "Move to icon" is shown on the customizer at least.

Still, the issues can be replicated.

@xpurichan
Copy link

Encountered on a Team 51 partner's website (Awesome.blog).

@github-actions
Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 4924856-zen

@sejas
Copy link
Member

sejas commented Jul 21, 2022

In my opinion, this is a bad Gutenberg UX, not a bug.

In our documentation, we explain that the button to move the widget is this one:
Screenshot 2022-07-21 at 15 33 53

https://wordpress.com/support/widgets/#move-blocks-between-widget-areas

The decribed behaviour of move to is the same in a core website and also for blocks inside posts and pages. It only toggles the "view" from the Edit to the Select, so the user can drag and drop the block to another place.
IMO, It shouldn't show the dropdown with the widget areas.

It has been reported here: WordPress/gutenberg#35262

@happychait, what do you think?

@sejas sejas self-assigned this Jul 22, 2022
@vindl vindl added the Build Maintenance Build Group maintenance tasks label Aug 4, 2022
@sejas sejas removed their assignment Sep 16, 2022
@sejas
Copy link
Member

sejas commented Sep 16, 2022

I'm unassigning this issue since I'll be AFK for 2 weeks.
The best solution for this issue would be to remove, on Gutenberg core, the move to button from the components when we are on the widgets page:

Here is the component move to:
https://github.dev/WordPress/gutenberg/blob/trunk/packages/block-editor/src/components/block-settings-menu/block-settings-dropdown.js#L280

p1659026074019309-slack-C0347E545HR

@mpkelly
Copy link
Contributor

mpkelly commented Sep 29, 2022

I also had a quick look at this. I found that using Move to via the ellipsis menu does actually work but only if you use the arrow keys to move focus and then press Enter to move the selected block to its new location. You can see that here:

Move.to.mov

This is obviously not very clear and there should be some hints for the user. A keyboard shortcut for Move to would also be great, so you can initiate and complete the action entirely using the keyboard.

I checked the Gutenberg core repo but there doesn't appear to be an open issue there. I think this ticket should be moved to there and raised as a UX issue as per @sejas's comment. Although, FYI I wasn't able to get drag working after selecting Move to, so maybe that is an actual bug.

@happychait

@danielbachhuber
Copy link
Contributor

@mpkelly Want to create a detailed Gutenberg issue, and we can close this in favor of that one?

@cuemarie
Copy link

cuemarie commented Apr 12, 2023

It appears this has been resolved by WordPress/gutenberg#48113

Tested AT site with theme Twenty Twenty One, Twenty Seventeen

  • wpadmin widgets Move To button works on block widgets
  • Customize widgets Move To button works on block widgets

Tested Simple site with theme Twenty Seventeen

  • wpadmin widgets Move To button works on block widgets
  • Customize widgets Move To button works on block widgets

@cuemarie cuemarie added the [Closed] Resolved Issue is resolved. Use for issues that can be closed but did not have an explicit fix with a PR. label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Widgets Build Maintenance Build Group maintenance tasks [Closed] Resolved Issue is resolved. Use for issues that can be closed but did not have an explicit fix with a PR. Legacy Widgets [Pri] Normal [Type] Bug User Report This issue was created following a WordPress customer report
Projects
None yet
Development

No branches or pull requests

8 participants