Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toujours: Image Block Spacing #64994

Closed
i11za opened this issue Jun 27, 2022 · 3 comments · Fixed by WordPress/gutenberg#42005
Closed

Toujours: Image Block Spacing #64994

i11za opened this issue Jun 27, 2022 · 3 comments · Fixed by WordPress/gutenberg#42005
Labels
Needs triage Ticket needs to be triaged [Type] Bug

Comments

@i11za
Copy link

i11za commented Jun 27, 2022

Quick summary

When adding individual Image blocks to a post/page there is no spacing in preview/on live site between the blocks.

Steps to reproduce

On a site with a Toujours theme add several individual Image blocks.

What you expected to happen

To have additional spacing/padding between each individual image blocks both with and without captions.

Here's an example with Twenty Twenty-Two:

With captions:
image

Without captions:
image

What actually happened

On a site with Toujours theme (both Simple and Atomic):

There's spacing/padding in the editor:

With captions:

image

Without captions:
image

Spacing disappears in preview/once published:

With captions (not so obvious, but already visible):
image

With captions:
image

Context

Customer report: 5328028-zd-woothemes

Replicated on test sites.

Simple, Atomic or both?

Simple, Atomic

Theme-specific issue?

Yes: Toujours

(Tested with Toujours and Twenty Twenty-Two)

Browser, operating system and other notes

No response

Reproducibility

Consistent

Severity

One

Available workarounds?

No response

Workaround details

It might be possible to fix this with CSS, but I didn't test it, and it wouldn't be applicable for the particular user since they're on a Personal plan.

@edwinho89
Copy link

edwinho89 commented Jun 28, 2022

I had a similar issue in 5322670-zd-woothemes , and I believe it may be something to do with previous cssminify that is missing the CSS below:

.wp-block-image {
    margin: 0 0 1em;
}

Reviewing the cache of the post from June 15th 2022, you can find it has the CSS above to append margin

Link to previous CSS file: https://s2.wp.com/_static/??-eJyNUu1SwyAQfCEPmlo1/eH4LHzc4LWQMBw05u2lmdqJaU39w7Dc7t4CJ4cIpu8ydlmGAtEXRx3LIZo+AAfyOC6QMMxP8r4soVcZLcSe8wKtyTwdkeUBc1TmCBO6of9wXalQY3K1klCemmexExupC3krte8nA51UGiXn0ePViDrjiz33YRnQkkKPYQoyA9GrERN4dMqMIlD3WF5rc/xL9Hf4KenszmrsSwaXyC5i/9siqUyd4wdy019kW9G0ogGmED1CwpPYSkucrwy4bzT7tvMH1PMQ1e0rrMgGsg7reFTKZQ8Zv9Yl0wBqHRMyQ10DlQD5s/aaJuUjvDevL7t289bu94dv1mQP8Q==?cssminify=yes

Screenshot of cached post.
image

Perhaps something has changed?

@edwinho89
Copy link

Left a comment on Slack: p1656407679159569-slack-C02A76B714Z

@rinazrina
Copy link

Encountered in 35991764-hc -- Revelar theme

We'll need to follow up with this user once the patch is deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs triage Ticket needs to be triaged [Type] Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants