Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE on Simple Sites: Global Styles "Block Spacing" not accepting changes #67344

Closed
ClassicRKR27 opened this issue Sep 2, 2022 · 14 comments
Closed
Assignees
Labels
[Platform] Simple [Pri] Normal Schedule for the next available opportuinity. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@ClassicRKR27
Copy link

Quick summary

I had a user trying to figure out how to adjust the spacing between their header and the rest of their content within FSE, but every time they changed the measurement and saved the change would revert back to the default state. I tested this with an Atomic site which would accept the changes, but every theme I tried on a Simple site resulted in the same issue. I tested Disco, Appleton, Archeo and Meraki and they all could reproduce the error.

Steps to reproduce

  1. Set up an FSE theme on a Simple site
  2. Navigate to Global Styles > Layout
  3. Change the BLOCK SPACING amount and save the changes

What you expected to happen

The changes would be retained upon saving.

What actually happened

The settings revert back to default instantly.

Context

36731616-hc

Hn2dwe.mp4

Platform (Simple, Atomic, or both?)

Simple

Theme-specific issue?

No response

Browser, operating system and other notes

Replicated across Chrome, Firefox, and Safari.

Reproducibility

Consistent

Severity

All

Available workarounds?

Yes, easy to implement

Workaround details

Depending on how much they are wanting to change the only thing I've found to work is CSS - this user was fine with just CSS to address the issue with their header block but if they're expecting it to work on all of their blocks that would get complicated quickly.

@ClassicRKR27 ClassicRKR27 added [Type] Bug When a feature is broken and / or not performing as intended User Report labels Sep 2, 2022
@github-actions github-actions bot added [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. labels Sep 2, 2022
@zachspears
Copy link

Able to reproduce. Keeping Normal priority due to high impact.

@zachspears zachspears added the Triaged To be used when issues have been triaged. label Sep 7, 2022
@dpasque
Copy link
Contributor

dpasque commented Sep 20, 2022

I was doing some dogfooding on a site and ran into this, and wanted to add a little more information.

This actually seems to affect every setting under the Global Style Layout panel, not just block spacing. For example, you can't change the content width.

I also would recommend considering this for a higher priority, as the workaround for some of those settings can get a little tricky. For example, if you want to change the content width style, you have to do some pretty-involved CSS to override the values (because of how the base CSS rules are applied).

@ClassicRKR27
Copy link
Author

  • We've got another report here: 14591634-hc

@Joshgrygiel
Copy link

Another here: 37265127-hc

@janmckell
Copy link

  • Another report here: 5594665-zd-woothemes

I also tested this, and I could replicate it on a simple site, on more than one theme, 'TwentyTwentyTwo' and 'Thriving Artist' (a paid theme).

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

Support References

This comment is automatically generated. Please do not edit it.

  • 5594665-zen
  • 5619686-zen
  • 5620083-zen
  • 5726870-zen

@devNigel
Copy link

  • Another report: 5619686-zd-woothemes

@sudeepbaral
Copy link

Another report where the layout dimensions change did not work.

  • 5620083-zen

@Copons
Copy link
Contributor

Copons commented Oct 13, 2022

@Addison-Stavlo I think it makes sense if Ajax grabs this issue. Feel free to remove it from your backlog, if you agree! 🙂
Also, on the off-chance someone has already started working on this, please reach out to us for pointers, suggestions, and whatnot!

@Addison-Stavlo
Copy link
Contributor

I think it makes sense if Ajax grabs this issue. Feel free to remove it from your backlog, if you agree! 🙂

Sounds great. Thanks @Copons !

@mmtr mmtr self-assigned this Oct 19, 2022
@mmtr
Copy link
Member

mmtr commented Oct 19, 2022

I think this happens because Simple sites are still not fully updated to WordPress 6.1 and they are lacking this changeset which allows the blockGap property to be at any level. I cannot reproduce this on Atomic sites running WordPress 6.0 or self-hosted Jetpack sites running WordPress 6.1 and the lastest version of Gutenberg.

@david-binda do you have any idea about how long would it take to have that changeset in wpcom?

EDIT: Also asked in p94tqY-sD-p2#comment-1385

EDIT2: After discussing it privately with David, he told me that the changeset should land in WPCOM anytime this week.

@mmtr
Copy link
Member

mmtr commented Nov 3, 2022

I took a deeper look at this since WP.com Simple sites are already running WP 6.1 and the issue is still present. Turns out that it's a Core bug that happens only when the KSES filters are active (which is the case of WP.com Simple sites), so I reported it in the Gutenberg repo: WordPress/gutenberg#45520

@connorhipps
Copy link

Found another case with Appleton here: 5726870-zd-woothemes

@Copons
Copy link
Contributor

Copons commented Nov 28, 2022

I will close this issue for now because it's a Core bug tracked by a Core Gutenberg issue (also assigned to the Ajax board).

@Copons Copons closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Platform] Simple [Pri] Normal Schedule for the next available opportuinity. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests