Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block links inherits color from List Block color in Global Styles #76735

Closed
liviopv opened this issue May 6, 2023 · 4 comments
Closed
Labels
Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions [Feature] Full Site Editor The site editor. [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. Needs triage Ticket needs to be triaged [Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug

Comments

@liviopv
Copy link

liviopv commented May 6, 2023

Quick summary

No response

Steps to reproduce

  1. In Global Styles, set a custom text color for the List Block
  2. In the Header Template part, set a custom text color for the Navigation Block that's different the color from Step 1
  3. Create a post or page and add a List Block to the content
  4. The Navigation Block will inherit the color from the List Block instead of the custom color defined at the block level

What you expected to happen

The Navigation Block should inherit the color defined at block level

What actually happened

The Navigation Block incorrectly inherits the color from a different ol/ul element in the page, the List Block

Browser

Google Chrome/Chromium

Context

Customer report

Platform (Simple, Atomic, or both?)

Simple, Atomic

Other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

Yes, easy to implement

Workaround details

Unset the custom color for the List Block, or override the menu color with CSS

@liviopv liviopv added [Type] Bug Needs triage Ticket needs to be triaged Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions labels May 6, 2023
@github-actions github-actions bot added the [Pri] TBD Review and assign an appropriate [Pri] label as soon as possible. label May 6, 2023
@liviopv
Copy link
Author

liviopv commented May 6, 2023

Possibly related to Automattic/themes#6589 and Automattic/themes#6602

@cuemarie
Copy link

cuemarie commented May 9, 2023

Looks related to these too:

Seems there's a larger underlying issue here where the Nav Block is inheriting more than just color (or padding, in the issus linked above) from the List block.

@cuemarie
Copy link

cuemarie commented May 9, 2023

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

  • Tested on Simple – Replicated
  • Replicable outside of Dotcom – Yes

📌 FINDINGS/SCREENSHOTS/VIDEO

  • I can replicate this issue, along with many other issues between the List block and other parts of a site, on TT3 in a self-hosted environment.

Please find triage notes and screen recordings on this issue:

📌 ACTIONS

@cuemarie cuemarie changed the title [Bug] Munchies: Navigation Block links inherits color from List Block color in Global Styles Navigation Block links inherits color from List Block color in Global Styles May 9, 2023
@cuemarie cuemarie added the [Feature] Full Site Editor The site editor. label May 9, 2023
@cuemarie cuemarie transferred this issue from Automattic/themes May 9, 2023
@cuemarie cuemarie added [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. [Pri] Normal Schedule for the next available opportuinity. Triaged To be used when issues have been triaged. and removed [Pri] TBD Review and assign an appropriate [Pri] label as soon as possible. labels May 9, 2023
@Copons
Copy link
Contributor

Copons commented Jun 1, 2023

Thanks for reporting this!

Since this is a Core bug, I'm going ahead with closing this issue.

Some reasonings:

  • The Core issue is already filed and briefly discussed, with a similar bug surfaced.
  • The bug might require a major foundational discussion of the editor itself (already started in the PR for the similar bug), which can't be a T-Rex endeavour, since we don't work full time on the editor. 😅
  • The bug affects only a fraction of Dotcom users, possibly power users at that.
  • There is a proposed easy workaround.

@Copons Copons closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions [Feature] Full Site Editor The site editor. [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. Needs triage Ticket needs to be triaged [Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug
Projects
None yet
Development

No branches or pull requests

3 participants