Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor Top Toolbar display issues From Gutenberg 16.x #79769

Closed
inaikem opened this issue Jul 23, 2023 · 12 comments
Closed

Editor Top Toolbar display issues From Gutenberg 16.x #79769

inaikem opened this issue Jul 23, 2023 · 12 comments
Labels
[Closed] Resolved Issue is resolved. Use for issues that can be closed but did not have an explicit fix with a PR. Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Post/Page Editor The editor for editing posts and pages. [Platform] Atomic [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug

Comments

@inaikem
Copy link
Contributor

inaikem commented Jul 23, 2023

Quick summary

With Top Toolbar selected, the bar “takes over” more horizontal space than expected in GB 16.x

A video (self-hosted) and screenshot (WPcom + Yoast) follow. Both browsers were at 1280px wide:

Self-hosted video:

84bdqr.mp4

WPcom + Yoast image:
image

As you can see, the default expanded state covers the Save Draft/Update buttons, and preview icon + some of the Publish button.

With plugins that add elements to the top bar active (Yoast in this case), the effect is more pronounced and looks like a glitch to the untrained eye.

Steps to reproduce

  1. Open a post.
  2. Select "Top Toolbar" from the GB settings panel.
  3. Expand/contract the toolbar using the double chevron icon.

What you expected to happen

I expected the toolbar to cover other elements on the right of the editor when necessary (lots of options).

What actually happened

Buttons on the right of the top toolbar were unecessarily covered.

Impact

All

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Simple, Atomic, Self-hosted

Logs or notes

I raised this in Slack via: p1690077406281749-slack-C0160HSMDQV

There is a companion issue in Core here: WordPress/gutenberg#52688

I've created this report for WPcom HEs who come across this issue and want to record interaction IDs/have some additional context.

@inaikem inaikem added [Type] Bug [Feature] Post/Page Editor The editor for editing posts and pages. User Report Needs triage Ticket needs to be triaged labels Jul 23, 2023
@github-actions github-actions bot added [Platform] Atomic [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts labels Jul 23, 2023
@inaikem inaikem changed the title Editor Toolbar display issues From Gutenber 16.x Editor Toolbar display issues From Gutenberg 16.x Jul 23, 2023
@zdenys
Copy link
Contributor

zdenys commented Jul 24, 2023

6559005-zd-woothemes

@github-actions
Copy link

github-actions bot commented Jul 24, 2023

Support References

This comment is automatically generated. Please do not edit it.

  • 6559005-zen
  • 6540504-zen
  • 6580703-zen

@annezazu
Copy link

Just want to note that this PR will fix the problem: WordPress/gutenberg#52722 Available in Gutenberg 16.4.

@cuemarie cuemarie added [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Jul 24, 2023
@cuemarie cuemarie changed the title Editor Toolbar display issues From Gutenberg 16.x Editor Top Toolbar display issues From Gutenberg 16.x Jul 24, 2023
@cuemarie
Copy link

cuemarie commented Jul 24, 2023

📌 NOTE

  • For any HEs with user reports of this, feel free to track here, but you can also let folks know that the fix for this should reach their sites in around 2 weeks (from date of comment).

If users need a workaround in the meantime, they can turn off the Top Toolbar and use the block toolbar instead.

@edwinho89
Copy link

6540504-zd-woothemes

@csabarakasz
Copy link

6580703-zd-woothemes

We worked on a different issue with the user, but I noticed the same error.

@annezazu
Copy link

annezazu commented Aug 9, 2023

GB 16.4 went out today but this was backported to 6.3 previously. Thus far, I can't replicate on WPCOM, unless I make the screen size a bit smaller:

top.toolbar.mov

Overall though, this problem should be resolved in most cases. Can someone confirm?

@cuemarie
Copy link

cuemarie commented Aug 9, 2023

Hey @annezazu ! I took a few recordings of the behavior I'm seeing on WPCOM, as well as on my self-hosted site for reference. I am not positive of what the intended behavior is as the top bar responds to narrowing screen sizes, so I didn't want to assume what was expected and what wasn't! Here are the highlights:

ON WPCOM

  • "Save Draft" is hidden whenever the top bar chevron is open on WPCOM, even if there's room in the bar for it
  • The rest of the Publish & other top buttons hide once the top bar reaches a certain width; very little overlap occurs with the "Publish" button before elements hide
  • Installing a plugin like Yoast still creates a more noticeable overlap, as that adds content to the top bar that the responsiveness doesn't seem to acknowledge.

OUTSIDE OF DOTCOM

  • "Save Draft" remains, but the S in "Save" gets hidden whenever the chevron is opened

Free Edge site - 16.4.0-rc.1

4uAzdO.mp4

Atomic - WP 6.3 + Gut 16.3

zMUDNC.mp4

Atomic - WP 6.3 + Gutenberg 16.4

voBHZ5.mp4

Atomic - WP 6.3 + Gutenberg 16.4, with Yoast installed (per OP example)

efRV9Y.mp4

For comparison:

Pressable Site - WP 6.3 + Gutenberg 16.4, all other plugins inactive

kvu4dV.mp4

@annezazu
Copy link

annezazu commented Aug 9, 2023

This is very helpful! Thank you. @draganescu can you follow up here?

@draganescu
Copy link

Yes - thank you for the very helpful and detailed issue. I'm sorry for the hassle.

They're known limitations of the current implementation which can't know how many pinned items are on the right of the header so with all the tweaking some overlap is bound to happen.

We're working to figure out the overall changes required to allow for a better implementation which places the toolbar in a flow context that does not overlap neighboring UI.

@draganescu
Copy link

I made WordPress/gutenberg#53526 for some options around sizing the toolbar when many plugins are enlarging the right side of the header.

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Aug 10, 2023
@inaikem
Copy link
Contributor Author

inaikem commented Aug 29, 2023

Merged into Core here:
WordPress/gutenberg#53526

Closing 👍

@inaikem inaikem closed this as completed Aug 29, 2023
@cuemarie cuemarie added the [Closed] Resolved Issue is resolved. Use for issues that can be closed but did not have an explicit fix with a PR. label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Closed] Resolved Issue is resolved. Use for issues that can be closed but did not have an explicit fix with a PR. Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Post/Page Editor The editor for editing posts and pages. [Platform] Atomic [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug
Projects
Development

No branches or pull requests

7 participants