Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg 16.7 RC: blank templates with only Pattern Placeholder in the block structure #82023

Closed
liviopv opened this issue Sep 21, 2023 · 9 comments · Fixed by Automattic/jetpack#33350
Assignees
Labels
[Closed] Fixed Issues explicitly fixed with PRs. Do not use for no longer reproducible issues. [Feature] Full Site Editor The site editor. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. Gutenberg RC Testing [Plugin] Jetpack [Pri] BLOCKER [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug

Comments

@liviopv
Copy link

liviopv commented Sep 21, 2023

Quick summary

When running Gutenberg 16.7 RC on a simple edge site, most templates are not loading any content when using a8c block themes. The Site Editor canvas will load a blank page or just text blocks with unstyled text. In most templates, the block structure only lists a Pattern Placeholder block similar to what we've seen before in #79145.

Potentially related to the introduction of Font Management pbxlJb-4wB-p2 I'm reporting in case it's something different.

CleanShot.2023-09-21.at.18.46.59.mp4
CleanShot 2023-09-21 at 09 40 16@2x

cc @dsas (since you handled the previous "Pattern Placeholder" issue) and @fullofcaffeine (as this is a blocker for merging 16.7)

Steps to reproduce

  1. Activate a a8c block theme (don't use TT3/TT2)
  2. Load the Site Editor

What you expected to happen

The templates should load correctly

What actually happened

No content or missing content in the templates.

Impact

Some (< 50%)

Available workarounds?

There is no user impact

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

@liviopv liviopv added [Type] Bug Needs triage Ticket needs to be triaged Gutenberg RC Testing [Feature] Full Site Editor The site editor. [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. labels Sep 21, 2023
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Sep 21, 2023
@cuemarie
Copy link

cuemarie commented Sep 21, 2023

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO
Replicated with Gutenberg: v16.7.0-rc.1 on a Free site created 2023-09-21. It seems like this is visible on TT3 (see 404 page, for example), but more visible on other themes:

TT3

7aUfbh.mp4

Stewart

KsjqQu.mp4

📌 Message to Author

  • @liviopv thanks for the report! I'll wait to escalate this further, since you've pinged a couple relevant folks already 👍

@cuemarie cuemarie added Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Sep 21, 2023
@dsas
Copy link
Contributor

dsas commented Sep 22, 2023

Looking at the backtrace the error is triggered from editor-beta, which is Jetpack. I'll try reproducing on .org with and without jetpack later.

@dsas
Copy link
Contributor

dsas commented Sep 22, 2023

I can't reproduce it on a dotorg JP site, with the GB beta plugin, without ETK (can't try with ETK that is busted) and with the Awburn theme.

I can't reproduce it on an atomic site with the GB beta plugin, with ETK and the Awburn theme.

I can reproduce it on a simple site with the edge sticker and the Awburn theme.

@dsas
Copy link
Contributor

dsas commented Sep 26, 2023

@fullofcaffeine this is still happening with rc2. Using the "awburn" theme, when editing the home template the code is:

<!-- wp:group {"style":{"border":{"top":{"color":"var:preset|color|secondary","style":"solid","width":"10px"},"right":[],"bottom":[],"left":[]},"position":{"type":"sticky","top":"0px"}},"layout":{"type":"default"}} -->
<div class="wp-block-group" style="border-top-color:var(--wp--preset--color--secondary);border-top-style:solid;border-top-width:10px"><!-- wp:template-part {"slug":"header","theme":"pub/awburn"} /--></div>
<!-- /wp:group -->

<!-- wp:pattern {"slug":"awburn/home"} /-->

<!-- wp:template-part {"slug":"footer-home","area":"footer","theme":"pub/awburn"} /-->

but the awburn/home pattern isn't rendering in the editor, just the front-end.

It's definitely a different bug to the similar sounding #79145 I worked on before - that was triggered by patterns using postTypes in metadata, which isn't the case here.

@liviopv
Copy link
Author

liviopv commented Sep 26, 2023

Switching priority to Blocker since it doesn't seem to be fixed by disabling the Font Management on WordPress.com as I hoped. Context: p1695732252770119?thread_ts=1695664978.633309-slack-CBTN58FTJ

@fullofcaffeine
Copy link
Contributor

Thanks for reaching out, I'll have a look at this today.

@ramonjd
Copy link
Member

ramonjd commented Sep 27, 2023

On WordPress.com, I can also reproduce the issue on a simple site with the edge sticker and the Awburn theme.

But on a local WordPress installation, I could not. I ran a check on the following:

  • WordPress 6.3 and Awburn theme
  • WordPress 6.3 with Gutenberg 16.7 and Awburn theme
  • WordPress 6.3 with Gutenberg trunk and Awburn theme
  • WordPress 6.3.1 and Awburn theme
  • WordPress 6.3.1 with Gutenberg 16.7 and Awburn theme
  • WordPress 6.3.1 with Gutenberg trunk and Awburn theme
  • WordPress 6.4-alpha with Gutenberg trunk and Awburn theme

All were working as expected in the Site/Post editors and frontend.

Is it just happening with themes based on Block Canvas?

@kraftbj
Copy link
Contributor

kraftbj commented Sep 27, 2023

Possibly relevant: to load beta blocks of Jetpack, you'll want to set JETPACK_BETA_BLOCKS PHP constant to true (e.g. in wp-config.php). WP.com does this but a stock install of Jetpack wouldn't.

@kraftbj
Copy link
Contributor

kraftbj commented Sep 27, 2023

I can duplicate the toLowerCase issue on a fresh WordPress site + Gutenberg RC + Jetpack + Jetpack beta blocks.

@cuemarie cuemarie added the [Closed] Fixed Issues explicitly fixed with PRs. Do not use for no longer reproducible issues. label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Closed] Fixed Issues explicitly fixed with PRs. Do not use for no longer reproducible issues. [Feature] Full Site Editor The site editor. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. Gutenberg RC Testing [Plugin] Jetpack [Pri] BLOCKER [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug
Development

Successfully merging a pull request may close this issue.

8 participants