Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VideoPress block: drag and drop mixed media not inserting all files on Dotcom sites when video is included #40469

Open
tanjoymor opened this issue Nov 12, 2024 · 2 comments
Open

VideoPress block: drag and drop mixed media not inserting all files on Dotcom sites when video is included #40469

tanjoymor opened this issue Nov 12, 2024 · 2 comments
Labels
[Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] VideoPress A feature to help you upload and insert videos on your site. [Focus] Compatibility Ensuring our products play well with third-parties [Platform] Atomic [Platform] Simple [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Pri] Normal [Status] Auto-allocated Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@tanjoymor
Copy link

tanjoymor commented Nov 12, 2024 •
edited
Loading

Quick summary

The feature released with GB 19.3 of: Drag and Drop: When dragging a mix of video, audio, and image blocks, create individual blocks as appropriate — WordPress/gutenberg#65144 – isn't working as expected on Simple or Atomic Dotcom sites, when a video file is part of the grouping.

Steps to reproduce

  1. Any Simple or Atomic Dotcom site that has GB 19.5.1 (haven't tested earlier versions)
  2. Drag and drop 2 or more mixed media files into the editor with at least one file being a video
  3. Only video files are getting added

What you expected to happen

I expected all of the files to be added via their respective blocks.

What actually happened

Only the video files are added.

Atomic Site:
https://github.com/user-attachments/assets/30321119-d688-48c2-baed-bdd8b70f82db

It's exactly the same on Simple sites.

Impact

Most (> 50%)

Available workarounds?

Yes, easy to implement

If the above answer is "Yes...", outline the workaround.

Add video files separate from other media types. Which defeats the purpose of the feature as released: WordPress/gutenberg#65144

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

Chrome Version 130.0.6723.69
@tanjoymor tanjoymor added [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Nov 12, 2024
@annezazu
Copy link

annezazu commented Nov 12, 2024 •
edited
Loading

I can replicate this on a simple site. In particular, if I include a video, VideoPress takes precedence. As a result, adding Jetpack tag to this as I wonder if VideoPress is interfering.

@annezazu annezazu added the [Feature] VideoPress A feature to help you upload and insert videos on your site. label Nov 12, 2024
@Robertght
Copy link

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated
  • Replicable outside of Dotcom – Yes

📌 FINDINGS/SCREENSHOTS/VIDEO

  • What forces the Videopress block is not the Videopress module itself but the Jetpack blocks. Even I turn off Videopress, the VideoPress block still shows up instead of the video block. The behavior is consistent on self-hosted too.

📌 ACTIONS

  • Triaged

@jeherve, This looks more like a dependency within Jetpack. However, I can't find an exact report for this in the Jetpack repo. Is it safe to move there?

@Robertght Robertght added Triaged and removed Needs triage Ticket needs to be triaged labels Dec 5, 2024
@jeherve jeherve transferred this issue from Automattic/wp-calypso Dec 5, 2024
@jeherve jeherve changed the title Drag and drop mixed media not inserting all files on Dotcom sites when video is included VideoPress block: drag and drop mixed media not inserting all files on Dotcom sites when video is included Dec 5, 2024
@jeherve jeherve added [Focus] Compatibility Ensuring our products play well with third-parties [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] VideoPress A feature to help you upload and insert videos on your site. [Focus] Compatibility Ensuring our products play well with third-parties [Platform] Atomic [Platform] Simple [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Pri] Normal [Status] Auto-allocated Triaged [Type] Bug When a feature is broken and / or not performing as intended
Projects
Automattic Prioritization: The One Board ™
Status: Triaged
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jeherve @Robertght @matticbot @annezazu @tanjoymor