Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: make "in-stream" comment bubble more useful #974

Closed
designsimply opened this issue Nov 29, 2015 · 5 comments
Closed

Reader: make "in-stream" comment bubble more useful #974

designsimply opened this issue Nov 29, 2015 · 5 comments
Labels
[Closed] Not Reproducible Issue cannot be reproduced. [Feature] Reader The reader site on Calypso. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@designsimply
Copy link
Contributor

Raised by @shaunandrews

When viewing your Reader stream, there's a handy comment count shown for posts that support it:

screen shot 2015-11-29 at 11 03 37

Unfortunately, this icon doesn't do anything when you click on it—well, it opens the full post view, but it feels like it should do something else. The easy solution is to have it open the full post view and scroll down to the comments. But this has issues, since we don't load the comments instantly when the full post view is opened. Anyways, it feels a little weak. Here's a solution that I think makes it easier to read and post comments quickly, without needing to open the full post view:

screen shot 2015-11-29 at sun nov 29 11 04 48 am

Clicking on the comment bubble would open a popover with the comment list. For longer threads, the popover will have its own scrolling. Thoughts?

Notes from @blowery

One niggle with inlining comments: we don't currently have a way to load more than the first "page" of comments. Because of how comments work in the API, our first page is the most recent 10 replies and all their replies.

This isn't great for the comment list in either place, but i feel like it's especially weird here, as we can't use IS to load more comments, like we were potentially planning to do on the full post view. We'll need some kind of button to initiate the load. Probably a "load earlier comments" button at the top of the list?

Note from @shaunandrews

Probably a "load earlier comments" button at the top of the list?

Ah yes, I recall exploring this earlier:

screen shot 2015-09-14 at 11 12 15 am

Additional discussion in 9911-gh-calypso-pre-oss but the notes above are the gist and the end result of the conversations to date.

@designsimply designsimply added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Feature] Reader The reader site on Calypso. labels Nov 29, 2015
@blowery blowery added this to the Reader: Feature Backlog milestone Dec 1, 2015
@lizkarkoski
Copy link

#2726 was closed as duplicate, but this issue does not mention mobile view. Right now on mobile, clicking the comment icon does not do anything. Whereas on desktop it opens the single post view.

@stale
Copy link

stale bot commented Jan 11, 2018

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week. If you would like it to remain open, can you please comment below and see what you can do to get things moving with this issue? Thanks! 🙏

@stale stale bot added the [Status] Stale label Jan 11, 2018
@blowery
Copy link
Contributor

blowery commented Jan 12, 2018

oldy-but-a-goody

@stale stale bot removed the [Status] Stale label Jan 12, 2018
@bluefuton bluefuton removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Jan 9, 2020
@github-actions
Copy link

This issue is stale because it has been 180 days with no activity. You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation and apply one of relevant issue close labels.

@worldomonation
Copy link
Contributor

Hi! I'm performing triage on older bugs as part of Quality Squad's efforts to cut down on backlog issue counts.

I tried on both Desktop and Mobile web versions and found that clicking on the Comment icon from Reader view did open up the article in question and scrolled down to the comments field.

In light of this, I propose that this issue be closed as Closed - Not Reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Closed] Not Reproducible Issue cannot be reproduced. [Feature] Reader The reader site on Calypso. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

5 participants