Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sell_multiplier only works in some cases #44

Open
Exanthiax opened this issue Oct 6, 2022 · 1 comment
Open

sell_multiplier only works in some cases #44

Exanthiax opened this issue Oct 6, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@Exanthiax
Copy link
Contributor

Describe the bug
Does not multiply when using commands or when not selling all.

To Reproduce
Steps to reproduce the behaviour:

  1. Using EconomyShopGUI:
    2.1. Run command /sellgui, put items in and sell, it does not multiply sell rewards.
    2.2. Run command /sellall, choose what items or where from, and sell, it does not multiply sell rewards.
    2.3. Run command /shop, head to the item you wish to sell, sell 1. it does not multiply sell rewards. However, selling all does multiply.
  2. Be sad.

Expected behaviour
It should multiply sell rewards from all channels.

Screenshots
image
image
image
image
image
image

Server Information (please complete the following information):

  • Version: This server is running Paper version git-Paper-191 (MC: 1.19.2) (Implementing API version 1.19.2-R0.1-SNAPSHOT) (Git: 928bcc8)
  • Version of plugin and eco. Eco:6.43.5. EcoArmor:7.124.1

Additional context
Nope

@Exanthiax Exanthiax added the bug Something isn't working label Oct 6, 2022
@0ft3n
Copy link
Contributor

0ft3n commented Oct 9, 2022

Describe the bug Does not multiply when using commands or when not selling all.

To Reproduce Steps to reproduce the behaviour:

  1. Using EconomyShopGUI:
    2.1. Run command /sellgui, put items in and sell, it does not multiply sell rewards.
    2.2. Run command /sellall, choose what items or where from, and sell, it does not multiply sell rewards.
    2.3. Run command /shop, head to the item you wish to sell, sell 1. it does not multiply sell rewards. However, selling all does multiply.
  2. Be sad.

Expected behaviour It should multiply sell rewards from all channels.

Screenshots image image image image image image

Server Information (please complete the following information):

  • Version: This server is running Paper version git-Paper-191 (MC: 1.19.2) (Implementing API version 1.19.2-R0.1-SNAPSHOT) (Git: 928bcc8)
  • Version of plugin and eco. Eco:6.43.5. EcoArmor:7.124.1

Additional context Nope

Our integration uses PreTransactionEvent from EconomyShopGUI, so ask their developers why does this event not fire in some cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants