Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should getWallets require a parameter of factoryAddress, similar to getWallet? #73

Closed
chrisli30 opened this issue Dec 16, 2024 · 2 comments
Labels
completed P2 Priority Level 2 question Further information is requested

Comments

@chrisli30
Copy link
Member

Since we added a factoryAddress param to getWallet, getWallets seems to need it too.

Currently,

getWallet(salt, factoryAddress, options);

getWallets(options);
@chrisli30 chrisli30 added P2 Priority Level 2 question Further information is requested labels Dec 16, 2024
@v9n
Copy link
Member

v9n commented Dec 16, 2024

@chrisli30 We already defined it but just haven't implement. In the avs.proto right now

message GetWalletReq {
  string salt = 1;
  // this is the factory address for the wallet, when leaving its empty, we will use our default factory address
  string factory_address = 2;
}


message ListWalletReq {
  // filter out by factory address or salt
  // otherwise return all the wallet
  string factory = 1; # TODO: VInh to rename this to factory_address for consistent
  string salt = 2;
}

We just haven't implement it

@v9n
Copy link
Member

v9n commented Dec 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed P2 Priority Level 2 question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants